linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "kefeng.wang" <kefeng.wang@linaro.org>
To: Tejun Heo <tj@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	wangkefeng.wang@huawei.com, xuwei5@hisilicon.com
Subject: [PATCH] ahci: disable ncq feature for hisilicon sata
Date: Tue, 10 Jun 2014 17:51:37 +0800	[thread overview]
Message-ID: <5396D529.308@linaro.org> (raw)
In-Reply-To: <20140514170757.GD15690@htj.dyndns.org>

NCQ feature is unsupported on hisilicon sata controller, so disable it.
This version of IP is used by hip04 and hix5hd2 soc.

Signed-off-by: Kefeng Wang <kefeng.wang@linaro.org>
---
 drivers/ata/ahci_platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index ebe505c..0cfda8b 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -58,7 +58,7 @@ static int ahci_probe(struct platform_device *pdev)
        }

        if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci"))
-               hflags |= AHCI_HFLAG_NO_FBS;
+               hflags = AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ;

        rc = ahci_platform_init_host(pdev, hpriv, &ahci_port_info,
                                     hflags, 0, 0);
-- 
1.7.9.5

  reply	other threads:[~2014-06-10  9:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  8:59 [PATCH v6 0/3] ahci: add support for hisilicon sata Kefeng Wang
2014-04-25  8:59 ` [PATCH v6 1/3] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS Kefeng Wang
2014-04-25  8:59 ` [PATCH v6 2/3] libahci_platform: add host_flags parameter in ahci_platform_init_host() Kefeng Wang
2014-04-25  8:59 ` [PATCH v6 3/3] ahci: add support for Hisilicon sata Kefeng Wang
2014-05-13 19:04   ` Tejun Heo
2014-05-14  6:12     ` kefeng.wang
2014-04-25 10:14 ` [PATCH v6 0/3] ahci: add support for hisilicon sata Hans de Goede
2014-05-05 12:05 ` kefeng.wang
2014-05-14 17:07 ` Tejun Heo
2014-06-10  9:51   ` kefeng.wang [this message]
2014-06-10 10:07     ` [PATCH] ahci: disable ncq feature " kefeng.wang
2014-06-10 13:56       ` Hans de Goede
2014-06-24  7:11         ` kefeng.wang
2014-06-24 20:56     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5396D529.308@linaro.org \
    --to=kefeng.wang@linaro.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=xuwei5@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).