From: Hans de Goede <hdegoede@redhat.com>
To: "kefeng.wang" <kefeng.wang@linaro.org>, Tejun Heo <tj@kernel.org>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
wangkefeng.wang@huawei.com, xuwei5@hisilicon.com
Subject: Re: [PATCH] ahci: disable ncq feature for hisilicon sata
Date: Tue, 10 Jun 2014 15:56:17 +0200 [thread overview]
Message-ID: <53970E81.1070608@redhat.com> (raw)
In-Reply-To: <5396D8C9.6020607@linaro.org>
Hi Kefeng,
On 06/10/2014 12:07 PM, kefeng.wang wrote:
> Hi Tejun,
>
> I have a question, the hip04 and hix5hd2 soc use the old version of IP, but they
> also have a new version of IP which support FBS and NCQ, and now the new one is
> used by a new soc. How can I distinguish them, use "hisilicon,hisi-ahci-vX" or just
> add "generic-ahci" string for the IP which is conformant with spec and has
> no special customization and issue? Any advices, thanks.
Please use "hisilicon,hisi-ahci-vX", this way it will be easier to add any
special behavior in case this turns out to be necessary later.
Regards,
Hans
next prev parent reply other threads:[~2014-06-10 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 8:59 [PATCH v6 0/3] ahci: add support for hisilicon sata Kefeng Wang
2014-04-25 8:59 ` [PATCH v6 1/3] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS Kefeng Wang
2014-04-25 8:59 ` [PATCH v6 2/3] libahci_platform: add host_flags parameter in ahci_platform_init_host() Kefeng Wang
2014-04-25 8:59 ` [PATCH v6 3/3] ahci: add support for Hisilicon sata Kefeng Wang
2014-05-13 19:04 ` Tejun Heo
2014-05-14 6:12 ` kefeng.wang
2014-04-25 10:14 ` [PATCH v6 0/3] ahci: add support for hisilicon sata Hans de Goede
2014-05-05 12:05 ` kefeng.wang
2014-05-14 17:07 ` Tejun Heo
2014-06-10 9:51 ` [PATCH] ahci: disable ncq feature " kefeng.wang
2014-06-10 10:07 ` kefeng.wang
2014-06-10 13:56 ` Hans de Goede [this message]
2014-06-24 7:11 ` kefeng.wang
2014-06-24 20:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53970E81.1070608@redhat.com \
--to=hdegoede@redhat.com \
--cc=kefeng.wang@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).