From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alexander E. Patrakov" Subject: Re: [RFC v2 6/6] pata_marvell: use async probe Date: Fri, 05 Sep 2014 12:59:49 +0600 Message-ID: <54095F65.6010405@gmail.com> References: <1409899047-13045-1-git-send-email-mcgrof@do-not-panic.com> <1409899047-13045-7-git-send-email-mcgrof@do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-lb0-f172.google.com ([209.85.217.172]:41178 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755939AbaIEG6d (ORCPT ); Fri, 5 Sep 2014 02:58:33 -0400 In-Reply-To: <1409899047-13045-7-git-send-email-mcgrof@do-not-panic.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: "Luis R. Rodriguez" , gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, falcon@meizu.com, tiwai@suse.de, tj@kernel.org, arjan@linux.intel.com Cc: linux-kernel@vger.kernel.org, oleg@redhat.com, hare@suse.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, joseph.salisbury@canonical.com, bpoirier@suse.de, santosh@chelsio.com, "Luis R. Rodriguez" , linux-ide@vger.kernel.org, One Thousand Gnomes 05.09.2014 12:37, Luis R. Rodriguez =EF=E8=F8=E5=F2: > From: "Luis R. Rodriguez" > > Alexander reported that on his Sony VAIO VPCZ23A4R laptop > experiences long delays on boot when connected to its dock > station on pre 3.9 kernels but anything after 3.9 will cause > the device to not be detected at all ending with: > > [ 38.065673] pata_marvell 0000:1a:00.0: no available native port > [ 38.065769] pata_acpi 0000:1a:00.0: no available native port I object to this commit message, it is based on outdated information an= d=20 is due to a different bug that was fixed in 3.10 as a last-minute fix.=20 Modern kernels just experience long delays during boot. > This laptop has a Marvell 88SE6121 SATA II Controller [11ab:6121] > and a BluRay writer attached. The reason for the delays are > caused by SRST errors and the link being slow to respond. > The pata_marvell driver is a simple libata wrapper so the > real required changes need to be made on libata however not > many folks are around and available anymore with intimate > knowledge and experience with these devices. Alexander notes > that it may be that *any* ATA BMDMA controller that fails to > respond to an identify command until a reset or other device > poking might suffer from similar fate, this needs to be > investigated further. Using async probe the issue caused > by systemd killing the driver after taking over 30 seconds > on probe. > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D59581 > > Cc: Tejun Heo > Cc: linux-ide@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: One Thousand Gnomes > Cc: Oleg Nesterov > Cc: Benjamin Poirier > Cc: Greg Kroah-Hartman > Cc: patrakov@gmail.com > Reported-by: "Alexander E. Patrakov" > Signed-off-by: Luis R. Rodriguez > --- > drivers/ata/pata_marvell.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c > index ae9feb1..6a543b9 100644 > --- a/drivers/ata/pata_marvell.c > +++ b/drivers/ata/pata_marvell.c > @@ -175,6 +175,7 @@ static struct pci_driver marvell_pci_driver =3D { > .suspend =3D ata_pci_device_suspend, > .resume =3D ata_pci_device_resume, > #endif > + .driver.async_probe =3D true, > }; > > module_pci_driver(marvell_pci_driver); > --=20 Alexander E. Patrakov