From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports Date: Thu, 08 Jan 2015 15:50:07 +0800 Message-ID: <54AE36AF.3070603@linaro.org> References: <1418337070-17644-1-git-send-email-fkan@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Feng Kan , patches , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Mark Salter , tj@kernel.org, hdegoede@redhat.com List-Id: linux-ide@vger.kernel.org Hi Feng Kan, I have some comments below. On 2015=E5=B9=B401=E6=9C=8808=E6=97=A5 01:32, Feng Kan wrote: > Just want to ping this again. > > Happy new year > > On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan wrote: >> This adds ACPI support for the APM X-Gene SATA ports. When the syste= m >> boots using ACPI table, the SATA ports are able to configure using t= he >> values supplied by the ACPI table rather than the DTS. >> >> Signed-off-by: Feng Kan >> --- >> drivers/ata/ahci_xgene.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c >> index d0c851a..4951392 100644 >> --- a/drivers/ata/ahci_xgene.c >> +++ b/drivers/ata/ahci_xgene.c >> @@ -22,6 +22,7 @@ >> * NOTE: PM support is not currently available. >> * >> */ >> +#include >> #include >> #include >> #include >> @@ -521,6 +522,14 @@ disable_resources: >> return rc; >> } >> >> +#ifdef CONFIG_ACPI >> +static const struct acpi_device_id xgene_ahci_acpi_match[] =3D { >> + { "APMC0D0D", }, When I was going through the PNP and ACPI ID list in http://www.uefi.org/PNP_ACPI_Registry, I found that there is no "APMC" for ACPI ID, I only found that there is a PNP ID "APM" for Applied Memory Tech company, are you using PNP ID for this one? if not, I think you can send a request to UEFI and request a new ACPI ID of "APMC" for Applied Micro, and then submit the patch again. How to send a request to register the ACPI ID, you can refer to: http://www.uefi.org/PNP_ACPI_Registry Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html