From: David Milburn <dmilburn@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: prevent HSM state change race between ISR and PIO
Date: Mon, 19 Jan 2015 12:03:23 -0600 [thread overview]
Message-ID: <54BD46EB.5080207@redhat.com> (raw)
In-Reply-To: <20150119174141.GB10570@htj.dyndns.org>
Hi Tejun,
On 01/19/2015 11:41 AM, Tejun Heo wrote:
> On Mon, Jan 19, 2015 at 10:27:31AM -0600, David Milburn wrote:
>> void ata_sff_flush_pio_task(struct ata_port *ap)
>> {
>> + struct Scsi_Host *host = ap->scsi_host;
>> + unsigned long flags;
>> +
>> DPRINTK("ENTER\n");
>>
>> cancel_delayed_work_sync(&ap->sff_pio_task);
>> +
>> + /* prevent racing with ISR's use of ap->hsm_task_state */
>
> Can we have a more descriptive comment please? lock, assign, unlock
> sequence is pretty unusual, so let's give the full explanation here.
>
Ok, will do.
Thanks,
David
prev parent reply other threads:[~2015-01-19 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 16:27 [PATCH] libata: prevent HSM state change race between ISR and PIO David Milburn
2015-01-19 17:41 ` Tejun Heo
2015-01-19 18:03 ` David Milburn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD46EB.5080207@redhat.com \
--to=dmilburn@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).