From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nicholas Mc Guire <hofrat@osadl.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Joe Perches <joe@perches.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ide_tape: convert jiffies with jiffies_to_msecs
Date: Tue, 03 Mar 2015 17:11:13 +0300 [thread overview]
Message-ID: <54F5C101.9070409@cogentembedded.com> (raw)
In-Reply-To: <1425379971-12641-1-git-send-email-hofrat@osadl.org>
Hello.
On 3/3/2015 1:52 PM, Nicholas Mc Guire wrote:
> Use jiffies_to_msecs for converting jiffies as it handles all of the corner
> cases reliably and also helps readability. The printk format is fixed up
> as jiffies_to_msecs returns unsigned int not unsigned long.
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> v2: change printk format string from %d to %u as suggested by
> Joe Perches <joe@perches.com>.
> Note that this patch will give a checkpatch warning due to "quoted string
> split across lines" but thats not related to this change.
> This was only compile tested with x86_64_defconfig + CONFIG_IDE=m,
> CONFIG_BLK_DEV_IDETAPE=m
> Patch is against 4.0-rc1 (localversion-next is -next-20150303)
>
> drivers/ide/ide-tape.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The driver is called ide-tape.c, yet your subject prefix is "ide_tape:".
WBR, Sergei
next prev parent reply other threads:[~2015-03-03 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:52 [PATCH v2] ide_tape: convert jiffies with jiffies_to_msecs Nicholas Mc Guire
2015-03-03 14:11 ` Sergei Shtylyov [this message]
2015-03-03 14:15 ` Nicholas Mc Guire
2015-03-03 14:22 ` Sergei Shtylyov
2015-03-20 9:54 ` Geert Uytterhoeven
2015-03-19 3:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5C101.9070409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).