From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: "Moore, Robert" <robert.moore@intel.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Zheng, Lv" <lv.zheng@intel.com>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"tj@kernel.org" <tj@kernel.org>,
"mjg59@srcf.ucam.org" <mjg59@srcf.ucam.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"al.stone@linaro.org" <al.stone@linaro.org>,
"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
"leo.duran@amd.com" <leo.duran@amd.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>
Subject: Re: [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing
Date: Mon, 30 Mar 2015 09:17:10 -0500 [thread overview]
Message-ID: <55195AE6.2050801@amd.com> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2A5F70@ORSMSX112.amr.corp.intel.com>
On 3/27/2015 12:51 PM, Moore, Robert wrote:
> + cls_objects = obj_desc->package.elements;
> +
> + if (obj_desc->common.type == ACPI_TYPE_PACKAGE &&
> + obj_desc->package.count == 3 &&
> + cls_objects[0]->common.type == ACPI_TYPE_INTEGER &&
> + cls_objects[1]->common.type == ACPI_TYPE_INTEGER &&
> + cls_objects[2]->common.type == ACPI_TYPE_INTEGER) {
> +
> + /* Allocate a buffer for the CLS */
> + cls = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_pnp_device_id) +
> + (acpi_size) 7);
>
> I would like to see an error returned if an object or subobject is of the incorrect type.
> Then, the caller knows not to attempt to look at it.
>
Ok. I will return AE_TYPE if the condition is false here.
Thanks,
Suravee
next prev parent reply other threads:[~2015-03-30 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 19:13 [V7 PATCH 0/3] Introduce ACPI support for ahci_platform driver Suravee Suthikulpanit
2015-03-26 19:13 ` [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing Suravee Suthikulpanit
2015-03-27 17:51 ` Moore, Robert
2015-03-30 14:17 ` Suravee Suthikulanit [this message]
2015-03-30 17:09 ` Moore, Robert
2015-03-26 19:13 ` [V7 PATCH 2/3] ACPI / scan: Add support for ACPI _CLS device matching Suravee Suthikulpanit
2015-03-26 19:13 ` [V7 PATCH 3/3] ata: ahci_platform: Add ACPI _CLS matching Suravee Suthikulpanit
2015-03-26 19:57 ` [V7 PATCH 0/3] Introduce ACPI support for ahci_platform driver Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55195AE6.2050801@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox