From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] Check return code from pdc20621_i2c_read()
Date: Mon, 3 Aug 2015 18:42:02 +0300
Message-ID: <55BF8BCA.40602@cogentembedded.com>
References: <1438510340-21568-1-git-send-email-barletz@gmail.com>
 <55BDFA5C.3040506@cogentembedded.com>
 <CAO-S75CRyh=FPbeTJMZWiYTvpd_wn57f4eGQgOHW2p16+9ANhQ@mail.gmail.com>
 <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Tomer Barletz <barletz@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: linux-ide@vger.kernel.org

On 08/02/2015 08:55 PM, Tomer Barletz wrote:

>>     Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead.

> Yeah, not sure what I was drinking before writing this 0x%d thing...

> Regarding the pr_err() - it is not used at all in this file, and
> printk() is used instead.

    The problem is these printk() calls cause complaints from 
scripts/checkpatch.pl.

> Wouldn't it be better to leave it with
> printk for this change, then have another change that replaces
> printk()s with pr_err()s?

    Probably yes...

> --Tomer

MBR, Sergei