Re: [PATCH v2] ata: ahci: find eSATA ports and flag them as removable

[Mark Lord <kernel@start.ca>]

On 15-09-30 05:39 PM, Tejun Heo wrote:
> On Wed, Sep 30, 2015 at 09:10:25PM +0200, Manuel Lauss wrote:
>> If the AHCI ports' HPCP or ESP bits are set, the port
>> should be considered external (e.g. eSATA) and is marked
>> as removable.  Userspace tools like udisks then treat it
>> like an usb drive.
>>
>> With this patch applied, when I plug a drive into the esata port,
>> KDE pops up a window asking what to do with the drives(s), just
>> like it does for any random USB stick.
>>
>> Removability is indicated to the upper layers by way of the
>> SCSI RMB bit, as I haven't found another way to signal
>> userspace to treat a sata disk like any usb stick.
>>
>> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
>
> Applied to libata/for-4.4.  Let's see what happens.

Ugh.  Yet another revert to include in my own builds, I guess.

eSATA is used for permanent storage expansion with port-multipliers,
and having to stop command queuing frequently for useless polling
is gonna be a performance drain.

-ml