From: Florian Fainelli <f.fainelli@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Tejun Heo <tj@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-ide@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Dragan Stancevic <dragan.stancevic@gmail.com>
Subject: Re: [v6 6/7] phy: phy_brcmstb_sata: add data for phy version
Date: Wed, 16 Dec 2015 16:46:58 -0800 [thread overview]
Message-ID: <56720602.3060906@gmail.com> (raw)
In-Reply-To: <8DDEF728-5E23-4357-98CB-F7D599F16337@gmail.com>
On 15/12/15 03:23, Jaedon Shin wrote:
>>> So an uninitialized .data field would mean the same?
>>
>> Are you planning to fix this?
>>
>> Thanks
>> Kishon
>
> No, I do not have a plan in this version.
>
> Of course, It is good that correspond to the case of NULL, but a .data field is not
> empty at any time. I'm sure it must have BRCM_SATA_PHY_28NM or BRCM_SATA_PHY_40NM.
>
> And Sergei, thanks to your good point.
I really do not this as a blocker to get these patches merged, and it
seems like we will miss another merge window on nitpicking if we
continue that route. Can we get these patches merged or are there more
blocking issues to be fixed?
--
Florian
next prev parent reply other threads:[~2015-12-17 0:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 2:56 [v6 0/7] add support SATA for BMIPS_GENERIC Jaedon Shin
2015-11-26 2:56 ` [v6 1/7] ata: ahci_brcmstb: add support for MIPS-based platforms Jaedon Shin
2015-11-26 2:56 ` [v6 2/7] ata: ahci_brcmstb: disable NCQ " Jaedon Shin
2015-11-26 2:56 ` [v6 3/7] ata: ahci_brcmstb: add a quirk " Jaedon Shin
2015-11-26 2:56 ` [v6 4/7] ata: ahci_brcmstb: remove unused definitions Jaedon Shin
2015-11-30 14:58 ` Tejun Heo
2015-11-26 2:56 ` [v6 5/7] phy: phy_brcmstb_sata: remove duplicate definitions Jaedon Shin
2015-11-26 2:56 ` [v6 6/7] phy: phy_brcmstb_sata: add data for phy version Jaedon Shin
2015-11-26 11:05 ` Sergei Shtylyov
2015-12-15 10:46 ` Kishon Vijay Abraham I
2015-12-15 11:23 ` Jaedon Shin
2015-12-17 0:46 ` Florian Fainelli [this message]
2015-11-26 2:56 ` [v6 7/7] phy: phy_brcmstb_sata: add support for MIPS-based platforms Jaedon Shin
2015-12-20 12:01 ` [v6 0/7] add support SATA for BMIPS_GENERIC Kishon Vijay Abraham I
2015-12-24 17:52 ` Florian Fainelli
2015-12-28 15:56 ` Tejun Heo
2016-01-01 2:21 ` Tejun Heo
2016-01-01 2:34 ` Jaedon Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56720602.3060906@gmail.com \
--to=f.fainelli@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dragan.stancevic@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=kishon@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).