From: Hans de Goede <hdegoede@redhat.com>
To: Tejun Heo <tj@kernel.org>, Brijesh Singh <brijesh.singh@amd.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver
Date: Tue, 26 Jan 2016 10:36:57 +0100 [thread overview]
Message-ID: <56A73E39.70109@redhat.com> (raw)
In-Reply-To: <20160125204300.GM3628@mtj.duckdns.org>
Hi,
On 25-01-16 21:43, Tejun Heo wrote:
> On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote:
>> AMD Seattle SATA controller mostly conforms to AHCI interface with some
>> special register to control SGPIO interface. In the case of an AHCI
>> controller, the SGPIO feature is ideally implemented using the
>> "Enclosure Management" register of the AHCI controller, but those
>> registeres are not implemented in the Seattle SoC. Instead SoC
>> (Rev B0 onwards) provides a 32-bit SGPIO control register which should
>> be programmed to control the activity, locate and fault LEDs.
>>
>> The driver is based on ahci_platform driver.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>> CC: tj@kernel.org
>> CC: linux-ide@vger.kernel.org
>
> Hans, can you please review the patch?
Done, driver looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
next prev parent reply other threads:[~2016-01-26 9:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:31 [PATCH v2] ata: add AMD Seattle platform driver Brijesh Singh
2016-01-20 21:24 ` Brijesh Singh
2016-01-25 20:43 ` Tejun Heo
2016-01-26 9:36 ` Hans de Goede [this message]
2016-03-16 20:12 ` Brijesh Singh
2016-01-26 12:17 ` Arnd Bergmann
2016-01-26 16:56 ` Brijesh Singh
2016-01-29 21:22 ` Arnd Bergmann
2016-01-29 21:31 ` One Thousand Gnomes
2016-02-01 18:56 ` Brijesh Singh
2016-02-01 20:14 ` Arnd Bergmann
2016-02-01 22:15 ` Brijesh Singh
2016-02-02 14:08 ` Arnd Bergmann
2016-02-02 18:37 ` Brijesh Singh
2016-02-05 14:50 ` Arnd Bergmann
2016-02-05 17:23 ` Brijesh Singh
2016-02-08 18:12 ` Brijesh Singh
2016-03-16 21:07 ` Tejun Heo
2016-03-17 17:36 ` Arnd Bergmann
2016-03-18 18:36 ` Brijesh Singh
2016-03-18 20:19 ` Tejun Heo
2016-04-14 9:08 ` Matthias Brugger
2016-04-14 22:14 ` Brijesh Singh
2016-04-13 19:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A73E39.70109@redhat.com \
--to=hdegoede@redhat.com \
--cc=arnd@arndb.de \
--cc=brijesh.singh@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).