Re: [PATCHv2 03/14] libsas: Define ATA_CMD_NCQ_NON_DATA

[Hannes Reinecke <hare@suse.de>]

On 04/14/2016 11:06 AM, John Garry wrote:
> On 12/04/2016 11:25, Hannes Reinecke wrote:
>> On 04/12/2016 12:03 PM, John Garry wrote:
>>> On 12/04/2016 07:47, Hannes Reinecke wrote:
>>>> Define the NCQ NON DATA command and update libsas to handle it
>>>> correctly.
>>>>
>>>> Signed-off-by: Hannes Reinecke <hare@suse.com>
>>>> ---
>>>>    drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
>>>>    drivers/scsi/isci/request.c            | 3 ++-
>>>>    drivers/scsi/libsas/sas_ata.c          | 3 ++-
>>>>    drivers/scsi/mvsas/mv_sas.c            | 3 ++-
>>>>    drivers/scsi/pm8001/pm8001_sas.c       | 3 ++-
>>>>    include/linux/ata.h                    | 1 +
>>>>    include/trace/events/libata.h          | 1 +
>>>>    7 files changed, 11 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>>>> b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>>>> index fc2e767..ebaf5ab 100644
>>>> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>>>> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>>>> @@ -1575,6 +1575,7 @@ static u8 get_ata_protocol(u8 cmd, int
>>>> direction)
>>>>        case ATA_CMD_FPDMA_READ:
>>>>        case ATA_CMD_FPMDA_RECV:
>>>>        case ATA_CMD_FPDMA_SEND:
>>>> +    case ATA_CMD_NCQ_NON_DATA:
>>>>        return SATA_PROTOCOL_FPDMA;
>>>>
>>>
>>> I'm going to double-check this. It may correspond to
>>> SATA_PROTOCOL_NONDATA, and not SATA_PROTOCOL_FPDMA.
>>>
> 
> So I got confirmation that SATA_PROTOCOL_FPDMA is correct for this
> type of command and we do support it.
> 
> If we want to test is it ok just to take this patchset and the other
> advised prerequisite patchsets?
> 
Yes, that should be sufficient.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)