From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
To: bzolnier@gmail.com, sshtylyov@ru.mvista.com
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] ide: fix Kconfig IDEPCI_SHARE_IRQ and IDEDISK_MULTI_MODE
Date: Mon, 22 Oct 2007 08:57:04 -0700 (PDT) [thread overview]
Message-ID: <573412.17797.qm@web52001.mail.re2.yahoo.com> (raw)
From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Correct IDEPCI_SHARE_IRQ description to keeping interrupts enabled
when calling the PCI IDE action handler. CONFIG_IDEPCI_SHARE_IRQ does not
affect the setting of IRQF_SHARED for PCI chipsets in function init_irq,
file drivers/ide/ide-probe.c but only the setting of IRQF_DISABLED.
Add IDEPCI_SHARE_IRQ and IDEDISK_MULTI_MODE help text from hdparm
manual page.
Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
---
Changing mention of multi-mode to affecting only some systems. Improving text.
--- a/drivers/ide/Kconfig 2007-10-21 08:53:11.826349500 +0300
+++ b/drivers/ide/Kconfig 2007-10-22 18:45:58.715425500 +0300
@@ -154,7 +154,19 @@ config BLK_DEV_IDEDISK
config IDEDISK_MULTI_MODE
bool "Use multi-mode by default"
help
- If you get this error, try to say Y here:
+ Multiple sector mode is a feature of most modern
+ IDE drives, permitting the transfer of multiple sectors per I/O
+ interrupt, rather than the usual one sector per interrupt.
+ When this feature is enabled, it can reduce operating
+ system overhead for disk I/O by 30 - 50%. On some systems, it
+ also provides increased data throughput of anywhere from 5%
+ to 50%. Some drives, however (most notably the WD Caviar
+ series), seem to run slower with multiple mode enabled. Some
+ drives claim to support multiple mode, but lose data at some
+ settings. Under rare circumstances, such failures can result
+ in massive filesystem corruption.
+
+ If you get the following error, try to say Y here:
hda: set_multmode: status=0x51 { DriveReady SeekComplete Error }
hda: set_multmode: error=0x04 { DriveStatusError }
@@ -367,11 +379,16 @@ config BLK_DEV_IDEPCI
bool
config IDEPCI_SHARE_IRQ
- bool "Sharing PCI IDE interrupts support"
+ bool "Keeping interrupts enabled when calling the PCI IDE action handler"
depends on BLK_DEV_IDEPCI
help
- Some ATA/IDE chipsets have hardware support which allows for
- sharing a single IRQ with other cards. To enable support for
+ A setting of Y permits the driver to enable other interrupts
+ during processing of a disk interrupt, which greatly improves
+ Linux's responsiveness and eliminates "serial port overrun"
+ and buffer errors. Use this feature with caution: some
+ drive/controller combinations do not tolerate the increased I/O
+ latencies possible when this feature is enabled, resulting in massive
+ filesystem corruption. To enable support for
this in the ATA/IDE driver, say Y here.
It is safe to say Y to this question, in most cases.
Machen Sie Yahoo! zu Ihrer Startseite. Los geht's:
http://de.yahoo.com/set
next reply other threads:[~2007-10-22 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 15:57 Matti Linnanvuori [this message]
2007-10-25 23:33 ` [PATCH] ide: fix Kconfig IDEPCI_SHARE_IRQ and IDEDISK_MULTI_MODE Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573412.17797.qm@web52001.mail.re2.yahoo.com \
--to=mattilinnanvuori@yahoo.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).