* [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT [not found] <20160704205335.5484-1-me> @ 2016-07-04 20:53 ` tom.ty89 2016-07-04 21:27 ` Sergei Shtylyov 0 siblings, 1 reply; 3+ messages in thread From: tom.ty89 @ 2016-07-04 20:53 UTC (permalink / raw) To: tj, martin.petersen; +Cc: linux-ide, linux-scsi, Tom Yan From: Tom Yan <tom.ty89@gmail.com> It does not make sense and is confusing to response with "Invalid field in cbd" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will response with "Invalid command operation code" instead. Signed-off-by: Tom Yan <tom.ty89@gmail.com> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 80d732c..f70f9d1 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4045,11 +4045,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd) args.done = cmd->scsi_done; switch(scsicmd[0]) { - /* TODO: worth improving? */ - case FORMAT_UNIT: - ata_scsi_invalid_field(dev, cmd, 0); - break; - case INQUIRY: if (scsicmd[1] & 2) /* is CmdDt set? */ ata_scsi_invalid_field(dev, cmd, 1); -- 2.9.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT 2016-07-04 20:53 ` [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT tom.ty89 @ 2016-07-04 21:27 ` Sergei Shtylyov 2016-07-04 21:31 ` Sergei Shtylyov 0 siblings, 1 reply; 3+ messages in thread From: Sergei Shtylyov @ 2016-07-04 21:27 UTC (permalink / raw) To: tom.ty89, tj, martin.petersen; +Cc: linux-ide, linux-scsi On 07/04/2016 11:53 PM, tom.ty89@gmail.com wrote: > From: Tom Yan <tom.ty89@gmail.com> > > It does not make sense and is confusing to response with "Invalid Respond here and in the subject. > field in cbd" while we have no support at all implemented for > FORMAT UNIT. It is decent to let it go to the default, which > will response with "Invalid command operation code" instead. > > Signed-off-by: Tom Yan <tom.ty89@gmail.com> MBR, Sergei ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT 2016-07-04 21:27 ` Sergei Shtylyov @ 2016-07-04 21:31 ` Sergei Shtylyov 0 siblings, 0 replies; 3+ messages in thread From: Sergei Shtylyov @ 2016-07-04 21:31 UTC (permalink / raw) To: tom.ty89, tj, martin.petersen; +Cc: linux-ide, linux-scsi On 07/05/2016 12:27 AM, Sergei Shtylyov wrote: >> From: Tom Yan <tom.ty89@gmail.com> >> >> It does not make sense and is confusing to response with "Invalid > > Respond here and in the subject. > >> field in cbd" while we have no support at all implemented for CDB. >> FORMAT UNIT. It is decent to let it go to the default, which >> will response with "Invalid command operation code" instead. >> Respond again. >> Signed-off-by: Tom Yan <tom.ty89@gmail.com> [...] MBR, Sergei ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-04 21:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160704205335.5484-1-me>
2016-07-04 20:53 ` [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT tom.ty89
2016-07-04 21:27 ` Sergei Shtylyov
2016-07-04 21:31 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox