* [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
@ 2016-07-12 10:59 Colin King
2016-07-12 11:04 ` Sergei Shtylyov
2016-07-26 22:26 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2016-07-12 10:59 UTC (permalink / raw)
To: David S . Miller, linux-ide; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
According to the HPT366 data sheet, PCI config space dword 0x40-0x43
bits 11:8 specify the primary drive cmd_high_time, however,
currently just 3 bits of the 4 are being used because the mask
is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
to be detected.
Also add in missing space between switch and parenthesis to clean
up a checkpatch warning.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/ide/hpt366.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c
index f94baad..f1dc6b6 100644
--- a/drivers/ide/hpt366.c
+++ b/drivers/ide/hpt366.c
@@ -1012,7 +1012,7 @@ static int init_chipset_hpt366(struct pci_dev *dev)
pci_read_config_dword(dev, 0x40, &itr1);
/* Detect PCI clock by looking at cmd_high_time. */
- switch((itr1 >> 8) & 0x07) {
+ switch ((itr1 >> 8) & 0x0f) {
case 0x09:
pci_clk = 40;
break;
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
2016-07-12 10:59 [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time Colin King
@ 2016-07-12 11:04 ` Sergei Shtylyov
2016-07-12 11:09 ` Sergei Shtylyov
2016-07-26 22:26 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2016-07-12 11:04 UTC (permalink / raw)
To: Colin King, David S . Miller, linux-ide; +Cc: linux-kernel
On 7/12/2016 1:59 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
> to be detected.
>
> Also add in missing space between switch and parenthesis to clean
> up a checkpatch warning.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
2016-07-12 11:04 ` Sergei Shtylyov
@ 2016-07-12 11:09 ` Sergei Shtylyov
2016-07-12 11:10 ` Colin Ian King
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2016-07-12 11:09 UTC (permalink / raw)
To: Colin King, David S . Miller, linux-ide; +Cc: linux-kernel
On 7/12/2016 2:04 PM, Sergei Shtylyov wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>> bits 11:8 specify the primary drive cmd_high_time, however,
>> currently just 3 bits of the 4 are being used because the mask
>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
>> to be detected.
>>
>> Also add in missing space between switch and parenthesis to clean
>> up a checkpatch warning.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
BTW, drivers/ata/pata_hpt366.c has the same bug...
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
2016-07-12 11:09 ` Sergei Shtylyov
@ 2016-07-12 11:10 ` Colin Ian King
2016-07-12 11:16 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2016-07-12 11:10 UTC (permalink / raw)
To: Sergei Shtylyov, David S . Miller, linux-ide; +Cc: linux-kernel
On 12/07/16 12:09, Sergei Shtylyov wrote:
> On 7/12/2016 2:04 PM, Sergei Shtylyov wrote:
>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>>> bits 11:8 specify the primary drive cmd_high_time, however,
>>> currently just 3 bits of the 4 are being used because the mask
>>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
>>> to be detected.
>>>
>>> Also add in missing space between switch and parenthesis to clean
>>> up a checkpatch warning.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> BTW, drivers/ata/pata_hpt366.c has the same bug...
OK, I'll fix that too in a moment.
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
2016-07-12 11:10 ` Colin Ian King
@ 2016-07-12 11:16 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2016-07-12 11:16 UTC (permalink / raw)
To: Colin Ian King, David S . Miller, linux-ide; +Cc: linux-kernel
On 7/12/2016 2:10 PM, Colin Ian King wrote:
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>>>> bits 11:8 specify the primary drive cmd_high_time, however,
>>>> currently just 3 bits of the 4 are being used because the mask
>>>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
>>>> to be detected.
>>>>
>>>> Also add in missing space between switch and parenthesis to clean
>>>> up a checkpatch warning.
>>>>
>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>
>>> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> BTW, drivers/ata/pata_hpt366.c has the same bug...
>
> OK, I'll fix that too in a moment.
TIA! Don't forget to increment the version though. :-)
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
2016-07-12 10:59 [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time Colin King
2016-07-12 11:04 ` Sergei Shtylyov
@ 2016-07-26 22:26 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2016-07-26 22:26 UTC (permalink / raw)
To: colin.king; +Cc: linux-ide, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Jul 2016 11:59:39 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
> to be detected.
>
> Also add in missing space between switch and parenthesis to clean
> up a checkpatch warning.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-26 22:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-12 10:59 [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time Colin King
2016-07-12 11:04 ` Sergei Shtylyov
2016-07-12 11:09 ` Sergei Shtylyov
2016-07-12 11:10 ` Colin Ian King
2016-07-12 11:16 ` Sergei Shtylyov
2016-07-26 22:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox