From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luben Tuikov Subject: Re: 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO) Date: Sat, 11 Nov 2006 11:09:33 -0800 (PST) Message-ID: <589461.23187.qm@web31813.mail.mud.yahoo.com> References: <20061111104642.GA3356@infradead.org> Reply-To: ltuikov@yahoo.com Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from web31813.mail.mud.yahoo.com ([68.142.207.76]:23920 "HELO web31813.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S1424606AbWKKTJe (ORCPT ); Sat, 11 Nov 2006 14:09:34 -0500 In-Reply-To: <20061111104642.GA3356@infradead.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Christoph Hellwig Cc: dougg@torque.net, Tejun Heo , Brice Goglin , Jens Axboe , Gregor Jasny , Linux Kernel , Jeff Garzik , linux-ide@vger.kernel.org, monty@xiph.org, linux-scsi@vger.kernel.org --- Christoph Hellwig wrote: > On Fri, Nov 10, 2006 at 12:08:15PM -0800, Luben Tuikov wrote: > > P.S. I'd love to see SG_DXFER_TO_FROM_DEV completely ripped out > > of sg.c, for obvious reasons. Can you not duplicate the resid "fix" > > it provides into "FROM_DEV" -- do apps really rely on it? > > At the beginning of this thread it was mentioned cdparanio uses it. > But in general we can't just rip out userland interfaces, we pretend > to have a stable userspace abi (and except for the big sysfs mess that > actually comes very close to the truth). The more reason to think things thorougly when introducing new code and architecture into a kernel. Luben > What we should do is to document very well what SG_DXFER_TO_FROM_DEV > is doing and that odd name that's been chosen for it. I'll prepare > a patch for that.