From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/1] build modular usb isd200 with modular ide Date: Tue, 26 Oct 2004 01:20:08 +0200 Sender: linux-ide-owner@vger.kernel.org Message-ID: <58cb370e0410251620279fb0ee@mail.gmail.com> References: <58cb370e041024054575c09679@mail.gmail.com> <200410252255.i9PMto6B024865@falcon10.austin.ibm.com> Reply-To: Bartlomiej Zolnierkiewicz Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from zeus.kernel.org ([204.152.189.113]:4051 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S261914AbUJZBTC (ORCPT ); Mon, 25 Oct 2004 21:19:02 -0400 Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.195]) by zeus.kernel.org (8.12.11/8.11.6) with ESMTP id i9PNQrrt024185 for ; Mon, 25 Oct 2004 16:26:54 -0700 Received: by wproxy.gmail.com with SMTP id 64so99192wri for ; Mon, 25 Oct 2004 16:26:48 -0700 (PDT) In-Reply-To: <200410252255.i9PMto6B024865@falcon10.austin.ibm.com> List-Id: linux-ide@vger.kernel.org To: Doug Maxey Cc: Christoph Hellwig , Paul Mackerras , Greg Kroah-Hartman , Linux SCSI Mailing List , Linux IDE Mailing List , linuxppc64-dev@ozlabs.org On Mon, 25 Oct 2004 17:55:50 -0500, Doug Maxey wrote: > >The dependency is a bug, is for IDE driver only. > > The isd200 _is_ a bridge to ATA/ATAPI devices. Does this mean it cannot use > common code, just because it is not in drivers/ide? no but the common ATA/ATAPI code resides in hdreg.h or/and ata.h, ide.h is for IDE driver _only_ > >Doug, if you kill debugging code in isd200.c then only: > > > >id->command_set_1 > >id->model > >id->fw_rev > >id->capability > >id->lba_capacity > >id->heads > >id->cyls > >id->sectors > >id->command_set_2 > > > >need to be byte-swapped. > > > > I don't plan on killing any debug code. I do :)