From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tobias Lorenz <tobias.lorenz@gmx.net>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.9-libata1-dev1] libata-scsi: hdparm support
Date: Tue, 2 Nov 2004 22:51:36 +0100 [thread overview]
Message-ID: <58cb370e041102135138f50dac@mail.gmail.com> (raw)
In-Reply-To: <4183B2C6.7090500@pobox.com>
On Sat, 30 Oct 2004 11:27:02 -0400, Jeff Garzik <jgarzik@pobox.com> wrote:
> Tobias Lorenz wrote:
> > Hi,
> >
> >
> >>This patch doesn't apply, since it is prefixed with "> " ...
> >
> > You are right... here is a corrected version.
> >
> > This patch adds support for transfering drive informations via the
> > hd_driveid structure to the hdparm utility. At the moment, only
> > cylinders, sectors, heads, model and firmware version are transfered.
>
> Applied to libata-dev... I'll need to ponder the correctness a bit
> more, before pushing upstream.
Speaking about correctness...
HDIO_GET_IDENTIFY returns ID block in CPU order (not LE).
If you decide to add it sooner or later you will need something ala
ide_fix_driveid() from ide-iops.c (bloat).
Bartlomiej
next prev parent reply other threads:[~2004-11-02 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 23:20 [PATCH 2.6.9-libata1-dev1] libata-scsi: hdparm support Tobias Lorenz
2004-10-23 12:36 ` Bartlomiej Zolnierkiewicz
2004-10-23 21:59 ` Tobias Lorenz
2004-10-30 12:43 ` Jeff Garzik
2004-10-30 14:58 ` Tobias Lorenz
2004-10-30 15:27 ` Jeff Garzik
2004-11-02 21:51 ` Bartlomiej Zolnierkiewicz [this message]
2004-11-04 16:55 ` Tobias Lorenz
2004-11-04 19:50 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e041102135138f50dac@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=tobias.lorenz@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).