From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: matthew@wil.cx, linux-ide@vger.kernel.org
Subject: Re: [PATCH] PA-RISC update to 87415
Date: Wed, 3 Nov 2004 21:21:02 +0100 [thread overview]
Message-ID: <58cb370e04110312215ee851e4@mail.gmail.com> (raw)
In-Reply-To: <20041103200059.GC17672@colo.lackof.org>
On Wed, 3 Nov 2004 13:00:59 -0700, Grant Grundler
<grundler@parisc-linux.org> wrote:
> Bartlomiej,
> Here's a "final" patch to cleanup the exporting of IDE data
> to suckyio support. I sent this before but it wasn't "verified"
> at the time:
> http://marc.theaimsgroup.com/?l=linux-ide&m=109587104530498&w=2
>
> It's verified now to work and should be applied.
thanks, looks OK
I only wonder about this change:
> @@ -132,10 +212,6 @@ static void __init init_hwif_ns87415 (id
> hwif->autodma = 0;
> hwif->selectproc = &ns87415_selectproc;
>
> - /* Set a good latency timer and cache line size value. */
> - (void) pci_write_config_byte(dev, PCI_LATENCY_TIMER, 64);
> - /* FIXME: use pci_set_master() to ensure good latency timer value */
> -
> /*
> * We cannot probe for IRQ: both ports share common IRQ on INTA.
> * Also, leave IRQ masked during drive probing, to prevent infinite
?
next prev parent reply other threads:[~2004-11-03 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 20:00 [PATCH] PA-RISC update to 87415 Grant Grundler
2004-11-03 20:21 ` Bartlomiej Zolnierkiewicz [this message]
2004-11-03 21:19 ` Grant Grundler
2004-11-03 21:33 ` Grant Grundler
2004-11-03 22:01 ` Bartlomiej Zolnierkiewicz
2004-11-03 23:19 ` Grant Grundler
2004-11-03 23:23 ` Grant Grundler
2004-11-05 20:17 ` Bartlomiej Zolnierkiewicz
2004-11-06 6:28 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04110312215ee851e4@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=linux-ide@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).