From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: PATCH: 2.6.10 - IT8212 IDE
Date: Wed, 29 Dec 2004 23:38:27 +0100 [thread overview]
Message-ID: <58cb370e04122914384fba1973@mail.gmail.com> (raw)
In-Reply-To: <1104355483.31622.2.camel@localhost.localdomain>
On Wed, 29 Dec 2004 21:24:45 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Mer, 2004-12-29 at 17:29, Bartlomiej Zolnierkiewicz wrote:
> > ide_get_best_pio_mode(drive, 4, 5, NULL) always returns 4
> > [ quick fix == hardcode 4 for now and add FIXME ]
>
> Doesn't seem that way reading the code.
u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8
max_mode, ide_pio_data_t *d)
{
/* mode_wanted == 4, max_mode == 5 */
...
if (mode_wanted != 255) {
/* 4 != 255 */
pio_mode = mode_wanted;
/* pio_mode == 4 */
} else if (!drive->id) {
pio_mode = 0;
} else if ((pio_mode = ide_scan_pio_blacklist(id->model)) != -1) {
overridden = 1;
blacklisted = 1;
use_iordy = (pio_mode > 2);
} else {
...
}
...
return pio_mode;
}
prev parent reply other threads:[~2004-12-29 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-28 15:16 PATCH: 2.6.10 - IT8212 IDE Alan Cox
2004-12-29 5:44 ` Andre Hedrick
2004-12-29 17:29 ` Bartlomiej Zolnierkiewicz
2004-12-29 20:12 ` Alan Cox
2004-12-29 21:32 ` Bartlomiej Zolnierkiewicz
2004-12-29 21:24 ` Alan Cox
2004-12-29 22:38 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04122914384fba1973@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).