From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Prarit Bhargava <prarit@sgi.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH]: Suppress output of error messages for non-existant interfaces
Date: Sat, 15 Jan 2005 02:33:31 +0100 [thread overview]
Message-ID: <58cb370e050114173367f21873@mail.gmail.com> (raw)
In-Reply-To: <41E52E84.9040609@sgi.com>
On Wed, 12 Jan 2005 09:04:52 -0500, Prarit Bhargava <prarit@sgi.com> wrote:
> Suppress output of "Wait for ready failed before probe !" messages for
> non-existant interfaces.
>
> Please see
> http://marc.theaimsgroup.com/?l=linux-ide&m=110553792013649&w=2 for
> further context on this patch.
applied, thanks
> --- linux-2.5.orig/drivers/ide/ide-probe.c 2005-01-12 09:00:49.000000000 -0500
> +++ linux-2.5/drivers/ide/ide-probe.c 2005-01-12 09:01:25.000000000 -0500
> @@ -742,21 +742,21 @@
> * their reset sequence even when they are non-selected slave
> * devices, thus preventing discovery of the main HD
> *
> * Doing this wait-for-busy should not harm any existing configuration
> * (at least things won't be worse than what current code does, that
> * is blindly go & talk to the drive) and fix some issues like the
> * above.
> *
> * BenH.
> */
> - if (wait_hwif_ready(hwif))
> + if (wait_hwif_ready(hwif) == -EBUSY)
> printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name);
>
> /*
> * Second drive should only exist if first drive was found,
> * but a lot of cdrom drives are configured as single slaves.
> */
> for (unit = 0; unit < MAX_DRIVES; ++unit) {
> ide_drive_t *drive = &hwif->drives[unit];
> drive->dn = (hwif->channel ? 2 : 0) + unit;
> (void) probe_for_drive(drive);
>
prev parent reply other threads:[~2005-01-15 1:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 14:04 [PATCH]: Suppress output of error messages for non-existant interfaces Prarit Bhargava
2005-01-15 1:33 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e050114173367f21873@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=prarit@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).