From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Doug Maxey <dwm@austin.ibm.com>
Cc: Jens Axboe <axboe@suse.de>, Jeff Garzik <jgarzik@pobox.com>,
Linux IDE Mailing List <linux-ide@vger.kernel.org>
Subject: Re: simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive
Date: Fri, 28 Jan 2005 23:56:41 +0100 [thread overview]
Message-ID: <58cb370e05012814566dce888a@mail.gmail.com> (raw)
In-Reply-To: <200501282254.j0SMsnBu023405@falcon10.austin.ibm.com>
On Fri, 28 Jan 2005 16:54:49 -0600, Doug Maxey <dwm@austin.ibm.com> wrote:
>
> On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote:
> >> The datacenters/server folks that would be using these drives would
> >> expect them to remain as set. I have to check, but unless something
> >> has changed very recently in the kernel, setting with hdparm does not
> >> "stick" in the sense that the command succeeds to the disk, but no change
> >> is made to the barrier.
> >
> >It is not a problem for IDE driver (flushes become no-ops)
> >and this way you can later enable wcache and still use barries.
>
> Well that certainly simplfies things.
>
> How about this?
No go until 'drive->wcache' bug is fixed.
> ===== drivers/ide/ide-disk.c 1.115 vs edited =====
> --- 1.115/drivers/ide/ide-disk.c 2005-01-04 11:39:25 -06:00
> +++ edited/drivers/ide/ide-disk.c 2005-01-28 16:48:24 -06:00
> @@ -1083,7 +1083,7 @@ static void idedisk_setup (ide_drive_t *
> if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5)))
> drive->wcache = 1;
>
> - write_cache(drive, 1);
> + write_cache(drive, drive->wcache);
>
> /*
> * We must avoid issuing commands a drive does not understand
>
next prev parent reply other threads:[~2005-01-28 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 22:54 simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive Doug Maxey
2005-01-28 22:56 ` Bartlomiej Zolnierkiewicz [this message]
2005-01-28 22:59 ` Bartlomiej Zolnierkiewicz
2005-01-29 23:54 ` simple use wcache from drive Doug Maxey
2005-01-30 0:05 ` Bartlomiej Zolnierkiewicz
2005-01-30 0:19 ` Doug Maxey
2005-01-30 0:41 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e05012814566dce888a@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=axboe@suse.de \
--cc=dwm@austin.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).