* [PATCH] add missing space to printk in ide_allocate_dma_engine
@ 2005-02-02 20:36 Olaf Hering
2005-02-02 23:27 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2005-02-02 20:36 UTC (permalink / raw)
To: linux-ide
a space is missing.
diff -p -purN linux-2.6.11-rc2.orig/drivers/ide/ide-dma.c linux-2.6.11-rc2/drivers/ide/ide-dma.c
--- linux-2.6.11-rc2.orig/drivers/ide/ide-dma.c 2005-01-22 02:48:03.000000000 +0100
+++ linux-2.6.11-rc2/drivers/ide/ide-dma.c 2005-02-02 21:32:55.000000000 +0100
@@ -829,7 +829,7 @@ int ide_allocate_dma_engine (ide_hwif_t
if (hwif->dmatable_cpu)
return 0;
- printk(KERN_ERR "%s: -- Error, unable to allocate%s DMA table(s).\n",
+ printk(KERN_ERR "%s: -- Error, unable to allocate %s DMA table(s).\n",
(hwif->dmatable_cpu == NULL) ? " CPU" : "",
hwif->cds->name);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add missing space to printk in ide_allocate_dma_engine
2005-02-02 20:36 [PATCH] add missing space to printk in ide_allocate_dma_engine Olaf Hering
@ 2005-02-02 23:27 ` Bartlomiej Zolnierkiewicz
2005-02-02 23:29 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-02 23:27 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-ide
applied
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add missing space to printk in ide_allocate_dma_engine
2005-02-02 23:27 ` Bartlomiej Zolnierkiewicz
@ 2005-02-02 23:29 ` Bartlomiej Zolnierkiewicz
2005-02-02 23:36 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-02 23:29 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-ide
On Thu, 3 Feb 2005 00:27:34 +0100, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> applied
and reversed, missing space is here: " CPU"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add missing space to printk in ide_allocate_dma_engine
2005-02-02 23:29 ` Bartlomiej Zolnierkiewicz
@ 2005-02-02 23:36 ` Olaf Hering
2005-02-02 23:41 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2005-02-02 23:36 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
On Thu, Feb 03, Bartlomiej Zolnierkiewicz wrote:
> On Thu, 3 Feb 2005 00:27:34 +0100, Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com> wrote:
> > applied
>
> and reversed, missing space is here: " CPU"
This was my oops:
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
W82C105: IDE controller at PCI slot 0000:00:03.1
W82C105: chipset revision 5
W82C105: 100% native mode on irq 102
ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR_CPUS=128 NUMA PSERIES
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] add missing space to printk in ide_allocate_dma_engine
2005-02-02 23:36 ` Olaf Hering
@ 2005-02-02 23:41 ` Bartlomiej Zolnierkiewicz
2005-02-03 15:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-02 23:41 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-ide
On Thu, 3 Feb 2005 00:36:03 +0100, Olaf Hering <olh@suse.de> wrote:
> On Thu, Feb 03, Bartlomiej Zolnierkiewicz wrote:
>
> > On Thu, 3 Feb 2005 00:27:34 +0100, Bartlomiej Zolnierkiewicz
> > <bzolnier@gmail.com> wrote:
> > > applied
> >
> > and reversed, missing space is here: " CPU"
>
> This was my oops:
>
> Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
> ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
> W82C105: IDE controller at PCI slot 0000:00:03.1
> W82C105: chipset revision 5
> W82C105: 100% native mode on irq 102
> ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
> ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
> hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
> Oops: Kernel access of bad area, sig: 11 [#1]
> SMP NR_CPUS=128 NUMA PSERIES
Indeed there is a bug but a different one:
printk() parameters are interchanged.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add missing space to printk in ide_allocate_dma_engine
2005-02-02 23:41 ` Bartlomiej Zolnierkiewicz
@ 2005-02-03 15:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-03 15:00 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-ide
On Thu, 3 Feb 2005 00:41:38 +0100, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> On Thu, 3 Feb 2005 00:36:03 +0100, Olaf Hering <olh@suse.de> wrote:
> > On Thu, Feb 03, Bartlomiej Zolnierkiewicz wrote:
> >
> > > On Thu, 3 Feb 2005 00:27:34 +0100, Bartlomiej Zolnierkiewicz
> > > <bzolnier@gmail.com> wrote:
> > > > applied
> > >
> > > and reversed, missing space is here: " CPU"
> >
> > This was my oops:
> >
> > Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
> > ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
> > W82C105: IDE controller at PCI slot 0000:00:03.1
> > W82C105: chipset revision 5
> > W82C105: 100% native mode on irq 102
> > ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
> > ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
> > hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
> > Oops: Kernel access of bad area, sig: 11 [#1]
> > SMP NR_CPUS=128 NUMA PSERIES
>
> Indeed there is a bug but a different one:
> printk() parameters are interchanged.
Fix will be in the next ide-2.6 update (today).
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-02-03 15:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-02 20:36 [PATCH] add missing space to printk in ide_allocate_dma_engine Olaf Hering
2005-02-02 23:27 ` Bartlomiej Zolnierkiewicz
2005-02-02 23:29 ` Bartlomiej Zolnierkiewicz
2005-02-02 23:36 ` Olaf Hering
2005-02-02 23:41 ` Bartlomiej Zolnierkiewicz
2005-02-03 15:00 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).