From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] fix wrong __init usage in IDE PCI drivers
Date: Thu, 3 Feb 2005 15:26:09 +0100 [thread overview]
Message-ID: <58cb370e050203062679e156e4@mail.gmail.com> (raw)
In-Reply-To: <20050119114219.GA10965@lst.de>
Hi,
On Wed, 19 Jan 2005 12:42:19 +0100, Christoph Hellwig <hch@lst.de> wrote:
> On Sat, Jan 15, 2005 at 02:37:36AM +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Sun, 9 Jan 2005 14:19:59 +0100, Christoph Hellwig <hch@lst.de> wrote:
> > > PCI probe routines (and funcions called by them) must use __devinit
> > > as they can be called from PCI hotplug operations.
> > >
> > > While most of the drivers touched in the patch are for hardware that's
> > > soldered on mainboards we now have a fake PCI HP driver that allows
> > > hot remove / replug for them which they need to handle.
Heh, hot remove is unsupported currently so this is not a problem
at the moment. I queued your patch to be merged after hotplug is fixed.
> > Ugh... I really hate (lack of) flexibility of CONFIG_HOTPLUG...
> >
> > Shouldn't we have __fakedev{init,exit} ?
>
> This really gets a little too complex. We also tended to trade a tiny
> bit of vasted memory over complexity all the time in Linux's past..
agreed
prev parent reply other threads:[~2005-02-03 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 13:19 [PATCH] fix wrong __init usage in IDE PCI drivers Christoph Hellwig
2005-01-15 1:37 ` Bartlomiej Zolnierkiewicz
2005-01-19 11:42 ` Christoph Hellwig
2005-02-03 14:26 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e050203062679e156e4@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).