Re: ide-cd question

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thu, 3 Feb 2005 14:34:42 -0600, Stuart_Hayes@dell.com
<Stuart_Hayes@dell.com> wrote:
> 
> Why does ide-cd use "DRIVER(drive)->end_request()" instead of
> "cdrom_end_request()" in the function ide_cdrom_error when it wants to
> end a request that's exceeded ERROR_MAX errors?  (See code below.)

Please always give the kernel version you are referring to.
ide_cdrom_error() is gone in 2.6.11-rc2.

If there is a bug, it is in ide_cdrom_driver declaration.
.end_request is not set to ide_cdrom_error.

> With certain requests (GET_CONFIGURATION (0x46), in particular),
> DRIVER(drive)->end_request() is not actually ending the request, because
> rq->bio is not NULL--but it also is not clearing rq->errors, so this
> request ends up getting retried forever, but no more resets are
> attempted because rq->errors has exceeded ERROR_MAX.

I don't get this, maybe I'm looking at the wrong kernel version?

Bartlomiej