From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2.6.11-rc2 05/29] ide: merge pci driver .h's into .c's Date: Fri, 4 Feb 2005 03:00:09 +0100 Message-ID: <58cb370e0502031800667e1e06@mail.gmail.com> References: <20050202024017.GA621@htj.dyndns.org> <20050202024712.GF621@htj.dyndns.org> Reply-To: Bartlomiej Zolnierkiewicz Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit In-Reply-To: <20050202024712.GF621@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org List-Id: linux-ide@vger.kernel.org On Wed, 2 Feb 2005 11:47:12 +0900, Tejun Heo wrote: > > 05_ide_merge_pci_driver_hc.patch > > > > Merges drivers/ide/pci/*.h files into their corresponding *.c > > files. Rationales are > > 1. There's no reason to separate pci drivers into header and > > body. No header file is shared and they're simple enough. > > 2. struct pde_pci_device_t *_chipsets[] are _defined_ in the > > header files. That isn't the custom and there's no good > > reason to do differently in these drivers. > > 3. Tracking changelogs shows that the bugs fixed by 00 and 01 > > are introduced during mass-updating ide pci drivers by > > forgetting to update *.h files. > > Signed-off-by: Tejun Heo Please kill crap in these .h files before mering them with .c files, also split this patch on per driver changes. crap example looks like this: ;) > +#ifndef SPLIT_BYTE > +#define SPLIT_BYTE(B,H,L) ((H)=(B>>4), (L)=(B-((B>>4)<<4))) > +#endif > +#ifndef MAKE_WORD > +#define MAKE_WORD(W,HB,LB) ((W)=((HB<<8)+LB)) > +#endif