From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Bram Verweij <bram.verweij@wanadoo.nl>
Cc: linux-ide@vger.kernel.org
Subject: Re: PATCH: ALI15x3, 200GB HD, dma broken, no_lba48_dma
Date: Thu, 10 Mar 2005 17:30:57 +0100 [thread overview]
Message-ID: <58cb370e0503100830533f54b9@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.60.0503042332240.1782@thelonious.dnsalias.com>
good catch, I overlooked lba48 flag when introducing no_lba48_dma
I slightly modified your patch:
diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
--- a/drivers/ide/ide-disk.c 2005-03-10 16:07:50 +01:00
+++ b/drivers/ide/ide-disk.c 2005-03-10 16:07:50 +01:00
@@ -168,6 +168,8 @@
if (hwif->no_lba48_dma && lba48 && dma) {
if (block + rq->nr_sectors > 1ULL << 28)
dma = 0;
+ else
+ lba48 = 0;
}
if (!dma) {
@@ -181,7 +183,7 @@
/* FIXME: SELECT_MASK(drive, 0) ? */
if (drive->select.b.lba) {
- if (drive->addressing == 1) {
+ if (lba48) {
task_ioreg_t tasklets[10];
pr_debug("%s: LBA=0x%012llx\n", drive->name, block);
and applied it, thanks
Bartlomiej
prev parent reply other threads:[~2005-03-10 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 22:52 PATCH: ALI15x3, 200GB HD, dma broken, no_lba48_dma Bram Verweij
2005-03-10 16:30 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0503100830533f54b9@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=bram.verweij@wanadoo.nl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).