From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Meier <droebbel.melta@gmx.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: dma problems with via82cxxx after suspend
Date: Fri, 18 Mar 2005 17:27:30 +0100 [thread overview]
Message-ID: <58cb370e05031808273d396562@mail.gmail.com> (raw)
In-Reply-To: <1110822850.11750.0.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
On Mon, 14 Mar 2005 18:54:10 +0100, David Meier <droebbel.melta@gmx.de> wrote:
> I get DMA errors after resuming from suspend (S3).
>
> I had switched DMA off before suspending.
...
This should be fixed in ide-dev-2.6 tree and in -mm series.
Alternatively you can try attached patch.
Bartlomiej
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: via.patch --]
[-- Type: text/x-patch; name="via.patch", Size: 1214 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/02/03 21:47:18+01:00 bzolnier@trik.(none)
# [ide] fix via82cxxx resume failure
#
# With David Woodhouse <dwmw2@infradead.org>.
#
# On resume from sleep, via_set_speed() doesn't reinstate the correct
# mode, because it thinks the drive is already configured correctly.
#
# Also kill redundant printk, ide_config_drive_speed() warns about errors.
#
# drivers/ide/pci/via82cxxx.c
# 2005/02/03 21:47:05+01:00 bzolnier@trik.(none) +2 -5
# [ide] fix via82cxxx resume failure
#
diff -Nru a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
--- a/drivers/ide/pci/via82cxxx.c 2005-03-18 17:26:38 +01:00
+++ b/drivers/ide/pci/via82cxxx.c 2005-03-18 17:26:38 +01:00
@@ -332,11 +332,8 @@
struct ide_timing t, p;
unsigned int T, UT;
- if (speed != XFER_PIO_SLOW && speed != drive->current_speed)
- if (ide_config_drive_speed(drive, speed))
- printk(KERN_WARNING "ide%d: Drive %d didn't "
- "accept speed setting. Oh, well.\n",
- drive->dn >> 1, drive->dn & 1);
+ if (speed != XFER_PIO_SLOW)
+ ide_config_drive_speed(drive, speed);
T = 1000000000 / via_clock;
prev parent reply other threads:[~2005-03-18 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 17:54 dma problems with via82cxxx after suspend David Meier
2005-03-18 16:27 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e05031808273d396562@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=droebbel.melta@gmx.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).