Re: Multiple functionality breakages in 2.6.12rc3 IDE layer

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On 4/29/05, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Iau, 2005-04-28 at 21:41, Bartlomiej Zolnierkiewicz wrote:
> > On 4/28/05, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > Ages ago we added an ide_default driver to clean up all the corner cases
> >
> > s/clean up/hide/
> 
> Matter of opinion.

No, it hided holes in the locking which is getting fixed finally.

> > > for most users. You can no longer
> > >         - Control the bus state of an interface
> > >         - Reset an interface
> > >         - Add an interface if none exist
> > >         - Issue raw commands
> > >         - Get an objects bios geometry
> > >         - Read the identify data by ioctl (its still in proc but may be stale)
> >
> > Details please.
> 
> If you need details you shouldn't be maintaining that code. Its obvious

Give details or quit whining.

> why. You've disabled open() of a device with no bound driver.

Guess what open() for ide-default was doing in 2.6?

return -ENXIO;

and no it wasn't my change - it was the effect of fixing
locking of the higher layers.

> > No functionality was removed AFAIK, see the patches.  I spend quite
> > a bit of time making sure that nothing breaks up (I missed one special
> > case but somebody already posted patch to LKML fixing it).
> 
> Build a kernel without ide-cd. Now try and issue ioctls on it. Doesn't
> work any more does it.
> 
> >
> > These patches were posted at least two times to both linux-ide and
> > linux-kernel, they were in -mm for ages - were you hiding under the
> > rock?
> 
> No, just doing an MBA thesis, a job, learning a second language and
> trying to beat sense into our politicians. Now I come back to look at

It seems that they influenced you heavily...

> the ide layer ready for a 2.6.12 merge and its all a bit messy. The open
> code was clean and is now duplicated. Copies of subtly different per

You must be joking.

> driver gendisk/disk layer open routines have appeared that should be

Each change was given rationale and detailed changelog, 
maybe you should get familiar with them.  Also look for
patch converting device drivers to sysfs (posted few times).

> shared. The default driver handling has been removed and half the
> options for obscure systems have been marked obsolete in some Gnome like
> purge of functionality that might scare small children.
> 
> > > The ability to specify the IDE ports on the command line as needed for
> > > some Sony laptop installs have also become "obsolete" over time. They
> > > still appear to work but spew a warning that the user will soon be
> > > screwed.
> >
> > This was discussed few times already.
> 
> And the discussion lead to no fixes

So fix the real bugs and leave debugging stuff alone.

> > Alan, seriously, what is your problem?
> 
> The fact that the IDE layer appears to be getting worse not better,
> which given the starting point is a remarkable achievement.

Personal insults are easy, get technical facts.

Bartlomiej