From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-ide@vger.kernel.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org, christoph@lameter.com
Subject: Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
Date: Wed, 6 Jul 2005 16:35:11 +0200 [thread overview]
Message-ID: <58cb370e05070607351fe5eced@mail.gmail.com> (raw)
In-Reply-To: <20050706140933.GH21330@wotan.suse.de>
On 7/6/05, Andi Kleen <ak@suse.de> wrote:
> > drive->hwif check is redundant, please remove it
>
> It's not. My first version didn't have it but it still crashed.
> It's what actually prevents the crash.
> I also don't know why, but it's true.
very weird as HWIF(drive) == drive->hwif:
ide_hwif_t *hwif = HWIF(drive);
...
q = blk_init_queue_node(do_ide_request, &ide_lock,
pcibus_to_node(drive->hwif->pci_dev->bus));
if (!q)
return 1;
...
if (!hwif->rqsize) {
you should OOPS here
Bartlomiej
next prev parent reply other threads:[~2005-07-06 14:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-06 13:30 [PATCH] Fix crash on boot in kmalloc_node IDE changes Andi Kleen
2005-07-06 14:05 ` Bartlomiej Zolnierkiewicz
2005-07-06 14:09 ` Andi Kleen
2005-07-06 14:35 ` Bartlomiej Zolnierkiewicz [this message]
2005-07-06 18:21 ` Andi Kleen
2005-07-06 16:34 ` Christoph Lameter
2005-07-06 16:45 ` Andi Kleen
2005-07-06 17:07 ` Christoph Lameter
2005-07-07 16:21 ` [another PATCH] " Christoph Lameter
2005-07-07 16:24 ` Andi Kleen
2005-07-07 16:32 ` Christoph Lameter
2005-07-07 16:36 ` Andi Kleen
2005-07-07 17:15 ` Christoph Lameter
2005-07-07 16:46 ` Bartlomiej Zolnierkiewicz
2005-07-07 16:38 ` Linus Torvalds
2005-07-07 16:40 ` Andi Kleen
2005-07-07 17:23 ` Christoph Lameter
2005-07-07 17:31 ` Jens Axboe
2005-07-07 18:57 ` Linus Torvalds
2005-07-07 19:09 ` Christoph Lameter
2005-07-07 21:15 ` Andi Kleen
2005-07-07 21:19 ` Bartlomiej Zolnierkiewicz
2005-07-07 21:25 ` Andi Kleen
2005-07-08 4:44 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e05070607351fe5eced@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=ak@suse.de \
--cc=christoph@lameter.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).