From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [another PATCH] Fix crash on boot in kmalloc_node IDE changes Date: Thu, 7 Jul 2005 23:19:04 +0200 Message-ID: <58cb370e050707141913e87371@mail.gmail.com> References: <20050706133052.GF21330@wotan.suse.de> <20050707211505.GM21330@wotan.suse.de> Reply-To: Bartlomiej Zolnierkiewicz Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from nproxy.gmail.com ([64.233.182.196]:4969 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S261487AbVGGVTH convert rfc822-to-8bit (ORCPT ); Thu, 7 Jul 2005 17:19:07 -0400 Received: by nproxy.gmail.com with SMTP id x4so76120nfb for ; Thu, 07 Jul 2005 14:19:04 -0700 (PDT) In-Reply-To: <20050707211505.GM21330@wotan.suse.de> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Andi Kleen Cc: Christoph Lameter , Linus Torvalds , linux-ide@vger.kernel.org, Linux Kernel Mailing List On 7/7/05, Andi Kleen wrote: > On Thu, Jul 07, 2005 at 12:09:00PM -0700, Christoph Lameter wrote: > > On Thu, 7 Jul 2005, Linus Torvalds wrote: > > > > > Yes. Except that if hwif is NULL, we'll have other oopses since we access > > > that in other places. > > > > > > Why _is_ hwif NULL anyway? That's another, unrelated thing, and should > > > probably have a separate check and an early return. > > > > I was wondering about that one as well. Andi brought it up. > > I don't know why hwif was NULL, but my kernel definitely crashed. > hwif was NULL in the first function (I first misread the oops > and thought it was pci_dev NULL, but it wasn't). For the second > I didn't verify it was hwif or pci_dev NULL, but one of them > was too. > > The setup was a Intel board with 1 PATA/4 SATA onboard and only a CD-ROM > and a external Promise PATA controller with two PATA disks. actual OOPS would be very useful