Re: Why toggle_bounce only for disks?

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

Hi,

http://www.ussg.iu.edu/hypermail/linux/kernel/0209.1/1074.html

Jens, is this still true??

Bartlomiej

On 8/7/05, Kyle McMartin <kyle@parisc-linux.org> wrote:
> Ahoi,
> 
> The following patch fixes a crash caused by attempting to bounce buffer
> when an IDE CD-ROM is used on a machine with an IO-MMU. [At least, this
> patch fixes things so I can use my IDE CD-ROM behind an ns87415 on a
> HP PA-RISC workstation.]
> 
> Why was this only allowed for disks?
> 
> --- a/drivers/ide/ide-lib.c   18 Jul 2005 18:46:30 -0000
> +++ b/drivers/ide/ide-lib.c   6 Aug 2005 20:28:04 -0000
> @@ -410,7 +410,7 @@ void ide_toggle_bounce(ide_drive_t *driv
>  {
>         u64 addr = BLK_BOUNCE_HIGH;     /* dma64_addr_t */
> 
> -       if (on && drive->media == ide_disk) {
> +       if (on) {
>                 if (!PCI_DMA_BUS_IS_PHYS)
>                         addr = BLK_BOUNCE_ANY;
>                 else if (HWIF(drive)->pci_dev)
> 
> Cheers,
> --
> Kyle McMartin