From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13 Date: Mon, 22 Aug 2005 12:19:38 +0200 Message-ID: <58cb370e05082203194cf1f424@mail.gmail.com> References: <1121894035.4885.15.camel@drevil.aslab.com> <20050728141242.GA10010@htj.dyndns.org> <4308D3D0.50504@pobox.com> <4308E7F4.3000509@gmail.com> <4308EDB5.6060102@pobox.com> <4308F5CD.7060001@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from zeus1.kernel.org ([204.152.191.4]:8328 "EHLO zeus1.kernel.org") by vger.kernel.org with ESMTP id S1751349AbVHVWT2 convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2005 18:19:28 -0400 Received: from nproxy.gmail.com (nproxy.gmail.com [64.233.182.193]) by zeus1.kernel.org (8.13.1/8.13.1) with ESMTP id j7MAKn9G006394 for ; Mon, 22 Aug 2005 03:20:50 -0700 Received: by nproxy.gmail.com with SMTP id x37so270692nfc for ; Mon, 22 Aug 2005 03:19:38 -0700 (PDT) In-Reply-To: <4308F5CD.7060001@gmail.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , Michael Madore , linux-ide@vger.kernel.org, albertcc@tw.ibm.com On 8/21/05, Tejun Heo wrote: > > Hello, Jeff. > > Jeff Garzik wrote: > > Tejun Heo wrote: > > > >> Jeff Garzik wrote: > >> > >>> Tejun Heo wrote: > >>> > >>>> Also, Jeff, I know you're very busy, but what do you think about > >>>> taking m15w workaround into ata tree? It's been around for a while > >>>> now and I haven't received any complaints (except for this one) yet. > >>>> The workaround is ugly but it surely helps and I'm willing to maintain > >>>> it. > > > > > >>> I think your mod15write solution is too messy to deal with long-term. > >>> Maintenance burden is much lower on us without it. It's not too > >>> difficult to simply avoid certain combinations of hardware. > > > > > >> No problem, I'll maintain it out of tree. > > > > > > You're welcome to maintain it as an independent branch of > > libata-dev.git, if you would prefer. > > > > I think I'll just keep it out of tree. I don't think many libata > developers would be interested in m15w workaround. > > > > >>> Note! As Carlos @ Silicon Image points out, the blacklist should > >>> only apply to SiI 3112, not 3512/3114/etc. That's an open FIXME that > >>> would benefit users. Weird, Windows drivers (at least *.INF files) seem to apply workarounds to both 3112 and 3512 while 3114 is OK. > > > > > >> Cool, I'll submit a patch right away. > > > > Can you please tell me which are affected and which are not? What about fixing 3114 for a start? :-) > { 0x1095, 0x3112, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > { 0x1095, 0x0240, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > { 0x1095, 0x3512, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > { 0x1095, 0x3114, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3114 }, > { 0x1002, 0x436e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > { 0x1002, 0x4379, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > { 0x1002, 0x437a, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > > Thanks. Bartlomiej