From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jens Axboe <axboe@suse.de>
Cc: Ravikiran G Thirumalai <kiran@scalex86.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shai Fultheim (Shai@scalex86.org)" <shai@scalex86.org>,
Alok Kataria <alokk@calsoftinc.com>
Subject: Re: [patch 0/4] ide: Break ide_lock to per-hwgroup lock
Date: Tue, 27 Sep 2005 15:36:40 +0200 [thread overview]
Message-ID: <58cb370e050927063674bb47a7@mail.gmail.com> (raw)
In-Reply-To: <20050907193422.GS4785@suse.de>
On 9/7/05, Jens Axboe <axboe@suse.de> wrote:
> On Wed, Sep 07 2005, Ravikiran G Thirumalai wrote:
> > On Wed, Sep 07, 2005 at 11:19:24AM +0200, Jens Axboe wrote:
> > > On Tue, Sep 06 2005, Ravikiran G Thirumalai wrote:
> > > > The following patchset breaks down the global ide_lock to per-hwgroup lock.
> > > > We have taken the following approach.
> > >
> > > Curious, what is the point of this?
> > >
> >
> > On smp machines with multiple ide interfaces, we take per-group lock instead
> > of a global lock, there by breaking the lock to per-irq hwgroups.
>
> I realize the theory behind breaking up locks, I'm just wondering about
> this specific case. Please show actual contention data promoting this
> specific case, we don't break up locks "just because".
>
> I'm asking because I've never heard anyone complain about IDE lock
> contention and a proper patch usually comes with analysis of why it is
> needed.
Since ide_lock spinlock is used for all drives as queue lock and for all
controllers as IDE lock I guess that with multiple controllers there is a lot
contention on it...
Breaking ide_lock is fine with me however seeing numbers would
greatly help in getting wider acceptance for this change, Ravikiran?
Bartlomiej
next prev parent reply other threads:[~2005-09-27 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 23:33 [patch 0/4] ide: Break ide_lock to per-hwgroup lock Ravikiran G Thirumalai
2005-09-06 23:37 ` [patch 1/4] ide: Break ide_lock -- Move hwif tuning code after hwif_init Ravikiran G Thirumalai
2005-09-06 23:40 ` [patch 2/4] ide: Break ide_lock -- replace ide_lock with hwgroup->lock in core ide Ravikiran G Thirumalai
2005-09-07 6:33 ` Ravikiran G Thirumalai
2005-09-06 23:42 ` [patch 3/4] ide: Break ide_lock -- change controller drivers Ravikiran G Thirumalai
2005-09-06 23:44 ` [patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver Ravikiran G Thirumalai
2005-09-07 17:06 ` Alan Cox
2005-09-07 17:50 ` Ravikiran G Thirumalai
2005-09-07 18:24 ` Alan Cox
2005-09-07 9:19 ` [patch 0/4] ide: Break ide_lock to per-hwgroup lock Jens Axboe
2005-09-07 19:27 ` Ravikiran G Thirumalai
2005-09-07 19:34 ` Jens Axboe
2005-09-27 13:36 ` Bartlomiej Zolnierkiewicz [this message]
2005-09-27 15:20 ` Ravikiran G Thirumalai
2005-09-27 15:26 ` Jens Axboe
2005-09-27 15:42 ` Ravikiran G Thirumalai
2005-09-27 15:58 ` Jens Axboe
2005-09-07 17:09 ` Alan Cox
2005-09-07 18:16 ` Ravikiran G Thirumalai
2005-09-07 19:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e050927063674bb47a7@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alokk@calsoftinc.com \
--cc=axboe@suse.de \
--cc=kiran@scalex86.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).