From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [git patches] 2.6.x libata updates Date: Tue, 3 Jan 2006 19:35:39 +0100 Message-ID: <58cb370e0601031035x89bd6cbw1e1efb3f7a93bb41@mail.gmail.com> References: <20060103164319.GA402@havoc.gtf.org> <58cb370e0601030851w62fc917bibe0fd5069b2f3e44@mail.gmail.com> <1136309555.22598.10.camel@localhost.localdomain> <43BAB7D4.4050204@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from nproxy.gmail.com ([64.233.182.194]:48282 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S932467AbWACSfl convert rfc822-to-8bit (ORCPT ); Tue, 3 Jan 2006 13:35:41 -0500 Received: by nproxy.gmail.com with SMTP id n15so923613nfc for ; Tue, 03 Jan 2006 10:35:40 -0800 (PST) In-Reply-To: <43BAB7D4.4050204@pobox.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Alan Cox , Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On 1/3/06, Jeff Garzik wrote: > Alan Cox wrote: > > On Maw, 2006-01-03 at 17:51 +0100, Bartlomiej Zolnierkiewicz wrote: > > > >>>+ * with SITRE and the 0x44 timing register). See pata_oldpiix and pata_mpiix > >>>+ * for the early chip drivers. > >> > >>pata_oldpiix and pata_mpiix are not in the mainline > > > > > > They are probably ready for mainline and since Linux currently has no > > support for either it might be nice to get them in. Anything specific > > they need polishing for Jeff ? > > Not really. If there's no support in mainline, I'm ok with pushing them > upstream... provided that they have been tested and verified to work on > at least one machine? :) All chipsets are supported by piix.c driver but: * we depend on BIOS to program correct PIO timings and set drives (mpiix chipset) * PIO tuning code is buggy and needs fixing (oldpiix chipsets) I don't think that this alone justify adding new drivers instead of fixing old one as both issues can be fixed quite easily by almost cut'n'pasting new tuning code from Alan's drivers and adding it to piix.c. Bartlomiej