From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: PATCH: (For review) Teach libata to tune master/slave seperately Date: Wed, 18 Jan 2006 13:44:01 +0100 Message-ID: <58cb370e0601180444i1af5a6c7y51156877db1ae826@mail.gmail.com> References: <1137531678.14135.105.camel@localhost.localdomain> <58cb370e0601180340v529c04fdq5dc962285a6fc1c0@mail.gmail.com> <1137585865.25819.27.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from uproxy.gmail.com ([66.249.92.203]:14372 "EHLO uproxy.gmail.com") by vger.kernel.org with ESMTP id S932481AbWARMoD convert rfc822-to-8bit (ORCPT ); Wed, 18 Jan 2006 07:44:03 -0500 Received: by uproxy.gmail.com with SMTP id s2so291658uge for ; Wed, 18 Jan 2006 04:44:01 -0800 (PST) In-Reply-To: <1137585865.25819.27.camel@localhost.localdomain> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, jgarzik@pobox.com On 1/18/06, Alan Cox wrote: > On Mer, 2006-01-18 at 12:40 +0100, Bartlomiej Zolnierkiewicz wrote: > > The core logic is changed (in the positive way): ata_pio_modes() > > is finally used for obtaining PIO mask to be used. > > Ah yes, Jeff hadn't previously merged the small version of that change. > Indeed description is a little incorrect. > > > Please update the patch description or make it a separate change. > > > > The other functional change is the ordering of programming host/devices: > > > > previously: > > * program PIO for device 0 [host] > > * program PIO for device 1 [host] > > * program DMA for device 0 [host] > > * program DMA for device 1 [host] > > * program xfer mode for device 0 [device] > > * program xfer mode for device 1 [device] > > > > now: > > * program PIO for device 0 [host] > > * program DMA for device 0 [host] > > * program xfer mode for device 0 [device] > > * program PIO for device 1 [host] > > * program DMA for device 1 [host] > > * program xfer mode for device 0 [device] > > > > This change is OK but I wonder what is the reason for it? > > It simply how suffling the code re-ordered it. I don't think its a > problem but if anyone has a problem I can go and re-re-order it. I think it is fine, no need for change. > libata also really should do adev->pio_mode = XFER_PIO_0; ->set_piomode > before doing its initial identify etc because there is no guarantee the > BIOS didn't leave the hardware in a bogus state. seconded Bartlomiej