From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bartlomiej Zolnierkiewicz" Subject: Re: Nvidia cable detection problems (was [PATCH] amd74xx: don't configure udma mode higher than BIOS did) Date: Mon, 5 Feb 2007 23:00:18 +0100 Message-ID: <58cb370e0702051400t2d3c08f1j83d7d1f74c36eb32@mail.gmail.com> References: <20070205075836.GG1625@htj.dyndns.org> <20070205143439.6962c076@localhost.localdomain> <45C7444F.4070500@gmail.com> <58cb370e0702050709w1b7682dr5dff9e7ce69465a@mail.gmail.com> <20070205181224.3319d6c3@localhost.localdomain> <45C77921.4020808@gmail.com> <58cb370e0702051055w3c7dcff3wd3e3b4935b910b41@mail.gmail.com> <58cb370e0702051327p7b253dafs439c937093ca837d@mail.gmail.com> <20070205220232.3e73297b@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.171]:2409 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964798AbXBEWAW (ORCPT ); Mon, 5 Feb 2007 17:00:22 -0500 Received: by ug-out-1314.google.com with SMTP id 44so1430284uga for ; Mon, 05 Feb 2007 14:00:19 -0800 (PST) In-Reply-To: <20070205220232.3e73297b@localhost.localdomain> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cc: Tejun Heo , Allen Martin , linux-ide@vger.kernel.org, linux-kernel On 2/5/07, Alan wrote: > > Since we are already using UDMA mode set by BIOS to determine if 80c cable > > is present so why not also use it to determine if the 40c cable is present? > > > > I mean just ignoring AMD_CABLE_DETECT register for NVIDIA devices. > > > > 2-lines change and we wouldn't have to deal with ACPI at ell. > > And as I explained earlier you get false values. The existing hack is > dodgy as well and breaks on suspend/resume then loading the driver for > one. It's probably the best that can be done without ACPI but the ACPI > _GTM/_STM methods are pretty clean so its not hard to use them. You need > them for full suspend/resume support anyway. OK