From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] scsi: ata: make ahci_sdev_attrs static
Date: Tue, 19 Oct 2021 20:27:10 -0700 [thread overview]
Message-ID: <59795405-fe7c-2181-b1a0-6beda1963911@acm.org> (raw)
In-Reply-To: <af043ccc-6287-47d4-d5b5-7bbef4e3380e@opensource.wdc.com>
On 10/19/21 15:44, Damien Le Moal wrote:
> +Bart
>
> On 2021/10/19 19:24, Jiapeng Chong wrote:
>> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The patch title should be:
>
> ata: libahci: make ahci_sdev_attrs static
>
>>
>> This symbol is not used outside of libahci.c, so marks it static.
>>
>> Fix the following sparse warning:
>>
>> drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
>> declared. Should it be static?
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
>> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>> ---
>> drivers/ata/libahci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
>> index 28430c093a7f..8a6835bfd18a 100644
>> --- a/drivers/ata/libahci.c
>> +++ b/drivers/ata/libahci.c
>> @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
>> };
>> EXPORT_SYMBOL_GPL(ahci_shost_groups);
>>
>> -struct attribute *ahci_sdev_attrs[] = {
>> +static struct attribute *ahci_sdev_attrs[] = {
>> &dev_attr_sw_activity.attr,
>> &dev_attr_unload_heads.attr,
>> &dev_attr_ncq_prio_supported.attr,
>>
>
> Looks OK to me.
The above patch looks fine to me too.
Thanks,
Bart.
next prev parent reply other threads:[~2021-10-20 3:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:24 [PATCH] scsi: ata: make ahci_sdev_attrs static Jiapeng Chong
2021-10-19 22:44 ` Damien Le Moal
2021-10-20 3:27 ` Bart Van Assche [this message]
2021-10-20 5:42 ` Damien Le Moal
2021-10-20 17:03 ` Bart Van Assche
2021-10-21 1:37 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59795405-fe7c-2181-b1a0-6beda1963911@acm.org \
--to=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox