From: arvindY <arvind.yadav.cs@gmail.com>
To: Joe Perches <joe@perches.com>,
b.zolnierkie@samsung.com, tj@kernel.org,
sergei.shtylyov@cogentembedded.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error
Date: Sat, 25 Nov 2017 16:40:14 +0530 [thread overview]
Message-ID: <5A194F96.2020605@gmail.com> (raw)
In-Reply-To: <1511607744.2503.1.camel@perches.com>
Hi Joe,
On Saturday 25 November 2017 04:32 PM, Joe Perches wrote:
> On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote:
> []
>> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
> []
>> @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed
>> */
>> static struct pdc2027x_pio_timing {
>> u8 value0, value1, value2;
>> -} pdc2027x_pio_timing_tbl [] = {
>> +} pdc2027x_pio_timing_tbl[] = {
>> { 0xfb, 0x2b, 0xac }, /* PIO mode 0 */
>> { 0x46, 0x29, 0xa4 }, /* PIO mode 1 */
>> { 0x23, 0x26, 0x64 }, /* PIO mode 2 */
> trivia:
>
> It seems all the <foo>_timing_tbl structs should be const
>
Yes, It should be const. I will push anther patch.
~arvind
next prev parent reply other threads:[~2017-11-25 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb@epcas5p1.samsung.com>
2017-11-25 10:34 ` [PATCH] pata_pdc2027x: Fix coding sytle error Arvind Yadav
2017-11-25 11:02 ` Joe Perches
2017-11-25 11:10 ` arvindY [this message]
2017-12-05 14:02 ` Bartlomiej Zolnierkiewicz
2017-12-05 14:12 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A194F96.2020605@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox