public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
* about warning in ata_eh_finish()
@ 2017-12-20  6:13 Jason Yan
  2017-12-20 17:36 ` Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2017-12-20  6:13 UTC (permalink / raw)
  To: tj, linux-ide

Hi, Tejun,

We often see this warning when using sata disks with libsas:

[26705.760518] WARNING: CPU: 1 PID: 6796 at drivers/ata/libata-eh.c:4037 
ata_eh_finish+0xb4/0xcc

[26706.350156] [<ffff0000088baf70>] ata_eh_finish+0xb4/0xcc
[26706.364260] [<ffff0000088bb764>] ata_do_eh+0x68/0xd8
[26706.377497] [<ffff0000088bb818>] ata_std_error_handler+0x44/0x8c
[26706.393406] [<ffff0000088bb408>] ata_scsi_port_error_handler+0x480/0x694
[26706.411352] [<ffff000008879364>] async_sas_ata_eh+0x4c/0x80
[26706.426133] [<ffff0000080f6be8>] async_run_entry_fn+0x4c/0x170
[26706.441841] [<ffff0000080ebd70>] process_one_work+0x144/0x390
[26706.457057] [<ffff0000080ec100>] worker_thread+0x144/0x418
[26706.471610] [<ffff0000080f2c98>] kthread+0x10c/0x138
[26706.484991] [<ffff0000080855dc>] ret_from_fork+0x10/0x18

This seems implies that ap->nr_active_links is wrong and should be zero.
But I didn't see any other errors. The disks work well.

Question:
ap->nr_active_links seems can be modified by different cpus 
simultaneously, should it be atomic_t? Is this the reason of the warning
above?


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-21  1:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20  6:13 about warning in ata_eh_finish() Jason Yan
2017-12-20 17:36 ` Tejun Heo
2017-12-21  1:31   ` Jason Yan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox