From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v9 1/6] block: add a sanity check for non-write flush/fua bios
Date: Wed, 11 Jan 2023 15:09:14 +0900 [thread overview]
Message-ID: <5d95dfcb-ce64-db64-046f-70376261345d@opensource.wdc.com> (raw)
In-Reply-To: <2544F354-58C0-4E90-8A1E-721AD455D6C8@kernel.dk>
On 1/11/23 13:32, Jens Axboe wrote:
> On Jan 10, 2023, at 2:58 PM, Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
>>
>> On 1/10/23 22:27, Damien Le Moal wrote:
>>> From: Christoph Hellwig <hch@infradead.org>
>>>
>>> Check that the PREFUSH and FUA flags are only set on write bios,
>>> given that the flush state machine expects that.
>>>
>>> [Damien] The check is also extended to REQ_OP_ZONE_APPEND operations as
>>> these are data write operations used by btrfs and zonefs and may also
>>> have the REQ_FUA bit set.
>>>
>>> Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>>> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
>>
>> Christoph, Jens,
>>
>> Are you OK with this patch ?
>
> I already acked a previous version, you just didn’t pick it up.
I noticed your ack. But since I changed the patch, I wanted confirmation
again. Do you want me to pickup this version through the ATA tree ?
You can take it through the block tree as the block patch can go in
separately. There are no conflicts/dependencies for compile with the ATA
part. Whichever is fine with me.
>
> —
> Jens Axboe
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-01-11 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:27 [PATCH v9 0/6] Improve libata support for FUA Damien Le Moal
2023-01-10 13:27 ` [PATCH v9 1/6] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2023-01-10 21:58 ` Damien Le Moal
2023-01-11 4:27 ` Christoph Hellwig
2023-01-11 4:32 ` Jens Axboe
2023-01-11 6:09 ` Damien Le Moal [this message]
2023-01-10 13:27 ` [PATCH v9 2/6] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2023-01-10 13:27 ` [PATCH v9 3/6] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2023-01-10 13:27 ` [PATCH v9 4/6] ata: libata: cleanup fua support detection Damien Le Moal
2023-01-10 13:27 ` [PATCH v9 5/6] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2023-01-10 13:27 ` [PATCH v9 6/6] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d95dfcb-ce64-db64-046f-70376261345d@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox