From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] ata: libata: Fix NCQ Non-Data log not supported print
Date: Tue, 18 Mar 2025 14:18:51 +0900 [thread overview]
Message-ID: <5db1373b-3136-4a43-a986-24715a8c5d18@kernel.org> (raw)
In-Reply-To: <20250317111754.1666084-2-cassel@kernel.org>
On 3/17/25 8:17 PM, Niklas Cassel wrote:
> Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
> Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
> which checks for NCQ Non-Data Log (Log Address 12h), uses the same
> print when the log is not supported:
>
> "NCQ Send/Recv Log not supported"
>
> This seems like a copy paste error, since NCQ Non-Data Log is actually
> a separate log.
>
> Fix the print the reference the correct log.
>
> Fixes: 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-03-18 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 11:17 [PATCH] ata: libata: Fix NCQ Non-Data log not supported print Niklas Cassel
2025-03-17 11:38 ` Hannes Reinecke
2025-03-18 5:18 ` Damien Le Moal [this message]
2025-03-18 8:05 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db1373b-3136-4a43-a986-24715a8c5d18@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox