[PATCH] ata: libata: Fix NCQ Non-Data log not supported print

[PATCH] ata: libata: Fix NCQ Non-Data log not supported print

[Niklas Cassel]

Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
which checks for NCQ Non-Data Log (Log Address 12h), uses the same
print when the log is not supported:

  "NCQ Send/Recv Log not supported"

This seems like a copy paste error, since NCQ Non-Data Log is actually
a separate log.

Fix the print the reference the correct log.

Fixes: 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/libata-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 193fc3942fd3a..e17e16706db70 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
 
 	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
 		ata_dev_warn(dev,
-			     "NCQ Send/Recv Log not supported\n");
+			     "NCQ Non-Data Log not supported\n");
 		return;
 	}
 	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,
-- 
2.48.1

Re: [PATCH] ata: libata: Fix NCQ Non-Data log not supported print

[Hannes Reinecke]

On 3/17/25 12:17, Niklas Cassel wrote:
> Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
> Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
> which checks for NCQ Non-Data Log (Log Address 12h), uses the same
> print when the log is not supported:
> 
>    "NCQ Send/Recv Log not supported"
> 
> This seems like a copy paste error, since NCQ Non-Data Log is actually
> a separate log.
> 
> Fix the print the reference the correct log.
> 
> Fixes: 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>   drivers/ata/libata-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 193fc3942fd3a..e17e16706db70 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2274,7 +2274,7 @@ static void ata_dev_config_ncq_non_data(struct ata_device *dev)
>   
>   	if (!ata_log_supported(dev, ATA_LOG_NCQ_NON_DATA)) {
>   		ata_dev_warn(dev,
> -			     "NCQ Send/Recv Log not supported\n");
> +			     "NCQ Non-Data Log not supported\n");
>   		return;
>   	}
>   	err_mask = ata_read_log_page(dev, ATA_LOG_NCQ_NON_DATA,

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH] ata: libata: Fix NCQ Non-Data log not supported print

[Damien Le Moal]

On 3/17/25 8:17 PM, Niklas Cassel wrote:
> Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
> Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
> which checks for NCQ Non-Data Log (Log Address 12h), uses the same
> print when the log is not supported:
> 
>   "NCQ Send/Recv Log not supported"
> 
> This seems like a copy paste error, since NCQ Non-Data Log is actually
> a separate log.
> 
> Fix the print the reference the correct log.
> 
> Fixes: 284b3b77ea88 ("libata: NCQ encapsulation for ZAC MANAGEMENT OUT")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: libata: Fix NCQ Non-Data log not supported print

[Niklas Cassel]

On Mon, 17 Mar 2025 12:17:55 +0100, Niklas Cassel wrote:
> Currently, both ata_dev_config_ncq_send_recv() - which checks for NCQ
> Send/Recv Log (Log Address 13h) and ata_dev_config_ncq_non_data() -
> which checks for NCQ Non-Data Log (Log Address 12h), uses the same
> print when the log is not supported:
> 
>   "NCQ Send/Recv Log not supported"
> 
> [...]

Applied to libata/linux.git (for-6.15), thanks!

[1/1] ata: libata: Fix NCQ Non-Data log not supported print
      https://git.kernel.org/libata/linux/c/b500ee5f

Kind regards,
Niklas