From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Mikko Korhonen <mjkorhon@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/7] ata: libata-eh: Drop dipm variable
Date: Thu, 15 May 2025 14:39:52 +0200 [thread overview]
Message-ID: <5fc39c58-83db-43f0-86d8-782fea550ed8@kernel.org> (raw)
In-Reply-To: <20250514172210.383801-12-cassel@kernel.org>
On 5/14/25 19:22, Niklas Cassel wrote:
> The dipm variable is confusing.
> Drop the variable and inline the expression at places where it is used.
>
> This will make it easier to perform additional cleanups.
>
> No functional change.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
I do not see the point of this patch given what patch 4 does. Can you squash 3
/7 and & 4/7 together ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-05-15 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 17:22 [PATCH 0/7] ata_eh_set_lpm() cleanups Niklas Cassel
2025-05-14 17:22 ` [PATCH 1/7] ata: libata-eh: Update DIPM comments to reflect reality Niklas Cassel
2025-05-14 17:22 ` [PATCH 2/7] ata: libata-eh: Add ata_eh_set_lpm() WARN_ON Niklas Cassel
2025-05-15 12:38 ` Damien Le Moal
2025-05-14 17:22 ` [PATCH 3/7] ata: libata-eh: Drop dipm variable Niklas Cassel
2025-05-15 12:39 ` Damien Le Moal [this message]
2025-05-14 17:22 ` [PATCH 4/7] ata: libata-eh: Introduce dev_has_dipm and dev_has_hipm variables Niklas Cassel
2025-05-14 17:22 ` [PATCH 5/7] ata: libata-eh: Rename no_dipm variable to be more clear Niklas Cassel
2025-05-14 17:22 ` [PATCH 6/7] ata: libata-eh: Host support has nothing to do with disabling DIPM Niklas Cassel
2025-05-14 17:22 ` [PATCH 7/7] ata: libata-eh: Always disable DIPM before calling set_lpm() callback Niklas Cassel
2025-05-15 12:42 ` Damien Le Moal
2025-05-15 12:59 ` Niklas Cassel
2025-05-15 13:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc39c58-83db-43f0-86d8-782fea550ed8@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mjkorhon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).