From: Scott Thompson <postfailathushmaildotcom@yahoo.com>
To: brandon@ifup.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org
Subject: [PATCH resubmit] /drivers/ata ioremap returncode check
Date: Thu, 23 Aug 2007 12:34:31 -0700 (PDT) [thread overview]
Message-ID: <648310.70195.qm@web44903.mail.sp1.yahoo.com> (raw)
Patchset against 2.6.23-rc3. corrects missing ioremap return
checks, resending after fixing for documentation making changes suggested...
As for suggestions, I did fix the {} that weren't needed. I did not add in a
"printk" err or warn statement as the rest of the module does not contain these
messages. When auditing (as I am for ioremap checking here) I am attempting
to keep changes "in the style of their surroundings". Otherwise it's massive
scope screep on these patches.
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
---------------------------------------------------------------
diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 4ca7fd6..6f9a2b7 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -189,6 +189,9 @@ static __devinit int ixp4xx_pata_probe(struct platform_device *pdev)
data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
+ if (!data->cs0 || !data->cs1)
+ return -ENOMEM;
+
irq = platform_get_irq(pdev, 0);
if (irq)
set_irq_type(irq, IRQT_RISING);
____________________________________________________________________________________
Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at
Yahoo! Games.
http://sims.yahoo.com/
____________________________________________________________________________________
Looking for a deal? Find great prices on flights and hotels with Yahoo! FareChase.
http://farechase.yahoo.com/
next reply other threads:[~2007-08-23 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 19:34 Scott Thompson [this message]
2007-09-03 8:29 ` [PATCH resubmit] /drivers/ata ioremap returncode check Tejun Heo
[not found] <20070823023328.19E6CDA82B@mailserver7.hushmail.com>
2007-08-23 2:47 ` Scott Thompson
2007-08-23 5:34 ` Brandon Philips
2007-08-23 17:42 ` Alexey Dobriyan
2007-08-23 17:53 ` Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=648310.70195.qm@web44903.mail.sp1.yahoo.com \
--to=postfailathushmaildotcom@yahoo.com \
--cc=brandon@ifup.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=postfail@hushmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).