From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B94C433EF for ; Tue, 22 Feb 2022 09:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbiBVJsx (ORCPT ); Tue, 22 Feb 2022 04:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbiBVJsx (ORCPT ); Tue, 22 Feb 2022 04:48:53 -0500 Received: from mxout04.lancloud.ru (mxout04.lancloud.ru [45.84.86.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2FA98F6C for ; Tue, 22 Feb 2022 01:48:25 -0800 (PST) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 65CC820DA1EC Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH] ata: pata_hpt37x: disable primary channel on HPT371 To: Damien Le Moal , References: From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <6604b1f6-adcf-96f6-f736-4ade3642f6f7@omp.ru> Date: Tue, 22 Feb 2022 12:48:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2/22/22 3:37 AM, Damien Le Moal wrote: >> HPT371 chips physically have only one channel, the secondary one, however >> the primary channel registers do exist! Thus we have to manually disable >> the non-existing channel (if the BIOS hasn't done this already). Alan Cox >> has only added such code to the 'pata_hpt3x2n' driver, forgetting about >> this one... :-/ > > No need to assign blame by name :) Something more neutral like: > > "Similarly to the pata_hpt3x2n driver, always disable the primary channel." Should I now repost? > will do. Also, do you have a fixes tag for this one ? Is it again: > > Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers.")> ? Yes. >> >> Signed-off-by: Sergey Shtylyov [...] MBR, Sergey