public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
@ 2025-12-09  4:24 Niklas Cassel
  2025-12-09  4:25 ` Niklas Cassel
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-12-09  4:24 UTC (permalink / raw)
  To: Damien Le Moal, Niklas Cassel; +Cc: Emerson Pinter, linux-ide

According to a user report, the ST2000DM008-2FR102 has problems with LPM.

Reported-by: Emerson Pinter <e@pinter.dev>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b96105481784..94c0e0ff981f 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4187,6 +4187,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 						ATA_QUIRK_NOLPM },
 	{ "VB0250EAVER",	"HPG7",		ATA_QUIRK_BROKEN_FPDMA_AA },
 
+	/* ST disks with LPM issues */
+	{ "ST2000DM008-2FR102",	NULL,		ATA_QUIRK_NOLPM },
+
 	/* Blacklist entries taken from Silicon Image 3124/3132
 	   Windows driver .inf file - also several Linux problem reports */
 	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_QUIRK_NONCQ },

base-commit: a26a0b4b48e181ff5ff340f9dc83612c74f2ccad
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
  2025-12-09  4:24 [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102 Niklas Cassel
@ 2025-12-09  4:25 ` Niklas Cassel
  2025-12-10  1:42 ` Damien Le Moal
  2025-12-16  5:30 ` Damien Le Moal
  2 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-12-09  4:25 UTC (permalink / raw)
  To: Damien Le Moal; +Cc: Emerson Pinter, linux-ide

On Tue, Dec 09, 2025 at 05:24:00AM +0100, Niklas Cassel wrote:
> According to a user report, the ST2000DM008-2FR102 has problems with LPM.
> 
> Reported-by: Emerson Pinter <e@pinter.dev>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---

Emerson,

could you please try to see if this patch solves your problem?

(Remove the libata.force from the kernel command line.)


Kind regards,
Niklas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
  2025-12-09  4:24 [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102 Niklas Cassel
  2025-12-09  4:25 ` Niklas Cassel
@ 2025-12-10  1:42 ` Damien Le Moal
  2025-12-10  2:29   ` Niklas Cassel
  2025-12-16  5:30 ` Damien Le Moal
  2 siblings, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2025-12-10  1:42 UTC (permalink / raw)
  To: Niklas Cassel; +Cc: Emerson Pinter, linux-ide

On 2025/12/08 20:24, Niklas Cassel wrote:
> According to a user report, the ST2000DM008-2FR102 has problems with LPM.
> 
> Reported-by: Emerson Pinter <e@pinter.dev>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  drivers/ata/libata-core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b96105481784..94c0e0ff981f 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4187,6 +4187,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  						ATA_QUIRK_NOLPM },
>  	{ "VB0250EAVER",	"HPG7",		ATA_QUIRK_BROKEN_FPDMA_AA },
>  
> +	/* ST disks with LPM issues */

s/ST/Seagate

Other than that, looks good.

> +	{ "ST2000DM008-2FR102",	NULL,		ATA_QUIRK_NOLPM },
> +
>  	/* Blacklist entries taken from Silicon Image 3124/3132
>  	   Windows driver .inf file - also several Linux problem reports */
>  	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_QUIRK_NONCQ },
> 
> base-commit: a26a0b4b48e181ff5ff340f9dc83612c74f2ccad


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
  2025-12-10  1:42 ` Damien Le Moal
@ 2025-12-10  2:29   ` Niklas Cassel
  2025-12-10  4:30     ` Damien Le Moal
  0 siblings, 1 reply; 6+ messages in thread
From: Niklas Cassel @ 2025-12-10  2:29 UTC (permalink / raw)
  To: Damien Le Moal; +Cc: Emerson Pinter, linux-ide

On Tue, Dec 09, 2025 at 05:42:37PM -0800, Damien Le Moal wrote:
> On 2025/12/08 20:24, Niklas Cassel wrote:
> > According to a user report, the ST2000DM008-2FR102 has problems with LPM.
> > 
> > Reported-by: Emerson Pinter <e@pinter.dev>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> >  drivers/ata/libata-core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index b96105481784..94c0e0ff981f 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4187,6 +4187,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> >  						ATA_QUIRK_NOLPM },
> >  	{ "VB0250EAVER",	"HPG7",		ATA_QUIRK_BROKEN_FPDMA_AA },
> >  
> > +	/* ST disks with LPM issues */
> 
> s/ST/Seagate
> 
> Other than that, looks good.

Perhaps you can fix up while applying?

Emerson sent me a message off list, confirming that the quirk is applied.


Kind regards,
Niklas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
  2025-12-10  2:29   ` Niklas Cassel
@ 2025-12-10  4:30     ` Damien Le Moal
  0 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2025-12-10  4:30 UTC (permalink / raw)
  To: Niklas Cassel; +Cc: Emerson Pinter, linux-ide

On 2025/12/09 18:29, Niklas Cassel wrote:
> On Tue, Dec 09, 2025 at 05:42:37PM -0800, Damien Le Moal wrote:
>> On 2025/12/08 20:24, Niklas Cassel wrote:
>>> According to a user report, the ST2000DM008-2FR102 has problems with LPM.
>>>
>>> Reported-by: Emerson Pinter <e@pinter.dev>
>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
>>> Signed-off-by: Niklas Cassel <cassel@kernel.org>
>>> ---
>>>  drivers/ata/libata-core.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>>> index b96105481784..94c0e0ff981f 100644
>>> --- a/drivers/ata/libata-core.c
>>> +++ b/drivers/ata/libata-core.c
>>> @@ -4187,6 +4187,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>>>  						ATA_QUIRK_NOLPM },
>>>  	{ "VB0250EAVER",	"HPG7",		ATA_QUIRK_BROKEN_FPDMA_AA },
>>>  
>>> +	/* ST disks with LPM issues */
>>
>> s/ST/Seagate
>>
>> Other than that, looks good.
> 
> Perhaps you can fix up while applying?

OK. Will do.


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102
  2025-12-09  4:24 [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102 Niklas Cassel
  2025-12-09  4:25 ` Niklas Cassel
  2025-12-10  1:42 ` Damien Le Moal
@ 2025-12-16  5:30 ` Damien Le Moal
  2 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2025-12-16  5:30 UTC (permalink / raw)
  To: Niklas Cassel; +Cc: Emerson Pinter, linux-ide

On 12/9/25 1:24 PM, Niklas Cassel wrote:
> According to a user report, the ST2000DM008-2FR102 has problems with LPM.
> 
> Reported-by: Emerson Pinter <e@pinter.dev>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220693
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  drivers/ata/libata-core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b96105481784..94c0e0ff981f 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4187,6 +4187,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  						ATA_QUIRK_NOLPM },
>  	{ "VB0250EAVER",	"HPG7",		ATA_QUIRK_BROKEN_FPDMA_AA },
>  
> +	/* ST disks with LPM issues */
> +	{ "ST2000DM008-2FR102",	NULL,		ATA_QUIRK_NOLPM },
> +
>  	/* Blacklist entries taken from Silicon Image 3124/3132
>  	   Windows driver .inf file - also several Linux problem reports */
>  	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_QUIRK_NONCQ },
> 
> base-commit: a26a0b4b48e181ff5ff340f9dc83612c74f2ccad

Applied to for-6.19-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-12-16  5:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-09  4:24 [PATCH] ata: libata-core: Disable LPM on ST2000DM008-2FR102 Niklas Cassel
2025-12-09  4:25 ` Niklas Cassel
2025-12-10  1:42 ` Damien Le Moal
2025-12-10  2:29   ` Niklas Cassel
2025-12-10  4:30     ` Damien Le Moal
2025-12-16  5:30 ` Damien Le Moal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox