From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS
Date: Thu, 13 Oct 2022 14:56:29 +0900 [thread overview]
Message-ID: <68788b58-1e5f-c629-e9cd-f198b50e6019@opensource.wdc.com> (raw)
In-Reply-To: <4442509.LvFx2qVVIh@steina-w>
On 10/13/22 14:55, Alexander Stein wrote:
> Hello Damien,
>
> Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
>> On 10/12/22 22:30, Alexander Stein wrote:
>>> Hello Fabio,
>>>
>>> Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
>>>> Hi Alexander,
>>>>
>>>> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
>>>>
>>>> <alexander.stein@ew.tq-group.com> wrote:
>>>>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
>>>>> Fix this by using the 'platform:' prefix and DRV_NAME.
>>>>
>>>> What about adding a Fixes tag?
>>>>
>>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>>
>>> Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
>>> which point auto loading stopped working (if it did at all).
>>
>> Given that the alias was wrong in the first place when added for a
>> platform driver, this I think should be a fix for:
>>
>> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")
>
> I was hesitating tagging the very first commit, not knowing if it did work at
> that time. But it seems reasonable.
Yep, I do not think this will hurt...
If someone think I am wrong, please scream !
>
>> I can add the Fixes tag when applying.
>
> Thanks!
>
> Best regards,
> Alexander
>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-10-13 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 13:11 [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS Alexander Stein
2022-10-12 13:23 ` Fabio Estevam
2022-10-12 13:30 ` Alexander Stein
2022-10-13 4:20 ` Damien Le Moal
2022-10-13 5:55 ` Alexander Stein
2022-10-13 5:56 ` Damien Le Moal [this message]
2022-10-17 3:02 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68788b58-1e5f-c629-e9cd-f198b50e6019@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox