Re: [PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

[Damien Le Moal <dlemoal@kernel.org>]

On 8/29/24 10:19 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based

s/could/can

Same comment for the other 2 patches. Other than that, looks good.
Feel free to add Sergey's review tag when sending v2. Thanks.

> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/ata/pata_ftide010.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
> index 4d6ef90ccc77..73a9a5109238 100644
> --- a/drivers/ata/pata_ftide010.c
> +++ b/drivers/ata/pata_ftide010.c
> @@ -549,6 +549,7 @@ static const struct of_device_id pata_ftide010_of_match[] = {
>  	{ .compatible = "faraday,ftide010", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, pata_ftide010_of_match);
>  
>  static struct platform_driver pata_ftide010_driver = {
>  	.driver = {

-- 
Damien Le Moal
Western Digital Research