Re: [PATCH v3] dt-bindings: imx-pata: Convert to dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 10/03/2024 12:52, Animesh Agarwal wrote:
> Ok noted,
> 
> I have now included the explanation.
> 
> Added imx31 in the next patch and tested. Changes of the conversion are now
> mentioned in the next patch.

Please respond inline, instead of top-posting, because it makes your
emails hard to follow.
https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340


> 
> On Sat, Mar 9, 2024 at 11:38 PM Krzysztof Kozlowski <
> krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 09/03/2024 17:07, Animesh Agarwal wrote:
>>> Convert the imx-pata bindings to DT schema.
>>>
>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>> ---
>>> Changes in v3:
>>> - added fsl,imx51-pata in compatible property
>>
>> Please explain the differences done during conversion in the commit msg.

How did you solve this?

>> There was no imx51 compatible in the binding before.
>>
>>>
>>> Changes in v2:
>>> - fixed style issues
>>> - compatible property now matches the examples
>>> - fixed yamllint warnings/errors
>>> ---
>>>  .../devicetree/bindings/ata/fsl,imx-pata.yaml | 40 +++++++++++++++++++
>>>  .../devicetree/bindings/ata/imx-pata.txt      | 16 --------
>>>  2 files changed, 40 insertions(+), 16 deletions(-)
>>>  create mode 100644
>> Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
>>>  delete mode 100644 Documentation/devicetree/bindings/ata/imx-pata.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
>> b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
>>> new file mode 100644
>>> index 000000000000..265ea80434e1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
>>> @@ -0,0 +1,40 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/ata/fsl,imx-pata.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Freescale i.MX PATA Controller
>>> +
>>> +maintainers:
>>> +  - Animesh Agarwal <animeshagarwal28@gmail.com>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    items:
>>> +      - enum:
>>> +          - fsl,imx51-pata
>>> +      - const: fsl,imx27-pata
>>
>> This allows only imx51 and disallows imx27 alone, which is not what old
------------------------------^^^^^^^^^^^^^^^^^^^^^
How did you solve this?

>> bindings were saying.


>>
>> The best if you just test it on DTS. Please run `make dtbs_check W=1`
>> (see Documentation/devicetree/bindings/writing-schema.rst or
>>
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
>>
>> You should see two warnings for imx31 and imx51. You need imx31 as well
>> (and changes against pure conversion should be mentioned in commit msg).

----------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

How did you solve this?


Best regards,
Krzysztof